Improve debugging experience

[ThisIsMissEm]

Currently if the requests to the GitHub API fail, then the process crashes, rather than printing information about the failure.

Additionally there's no "dry run" mode so you can test configuration. (e.g., do everything up until sendMail and then just print the output to the console)

This made it a little more difficult to deploy than I thought.

[ThisIsMissEm]

I ended up with this patch when running python 3.13, without it I was getting send failures due to starttls and I think the initial ehlo, even though that should have been fine. I was previously running under GitHub actions with python 3.11.

diff --git a/index.py b/index.py
index 185e11a..fa72f6d 100755
--- a/index.py
+++ b/index.py
@@ -791,29 +791,16 @@ def sendMail(
     return _sendMail(config, from_addr, to_addr, subject, m.getvalue())
 
 def _sendMail(config, from_addr, to_addr, subject, message):
-    if "SMTP_SSL" in config:
-        smtp = smtplib.SMTP_SSL
-    else:
-        smtp = smtplib.SMTP
     timeout = config.get("SMTP_TIMEOUT", 30)
     try:
-        with smtp(config["SMTP_HOST"], port=config["SMTP_PORT"], timeout=timeout) as server:
-            if "SMTP_TLS" in config:
-                server.ehlo()
-                context = ssl.SSLContext(ssl.PROTOCOL_TLS)
-                server.starttls(context=context)
-                server.ehlo()
-            if "SMTP_USERNAME" in config:
-                try:
-                    server.login(config["SMTP_USERNAME"], config["SMTP_PASSWORD"])
-                except smtplib.SMTPException as why:
-                    warn(f"SMTP login failure - {why}")
-                    return {}
-            try:
-                result = server.sendmail(from_addr, to_addr, message)
-            except smtplib.SMTPException as why:
-                warn(f"SMTP sendmail error: {why}")
-                return {}
+        with smtplib.SMTP(config["SMTP_HOST"], port=config["SMTP_PORT"], timeout=timeout) as server:
+            server.starttls()
+            server.login(config["SMTP_USERNAME"], config["SMTP_PASSWORD"])
+            server.sendmail(from_addr, to_addr, message)
+            warn(f"Sent from {from_addr} to {to_addr} successfully")
+    except smtplib.SMTPException as why:
+        warn(f"SMTP Exception: {why}")
+        return {}
     except smtplib.SMTPConnectError as why:
         warn(f"SMTP connect error: {why}")
         return {}
@@ -826,11 +813,11 @@ def warn(message):
     sys.stderr.write(f"WARNING: {message}\n")
 
 def getConfig():
-    config = json.loads(io.open("instance/config.json").read())
+    with io.open("instance/config.json") as file:
+        config = json.loads(file.read())
+
     for K in [
         "GH_OAUTH_TOKEN",
-        "SMTP_SSL",
-        "SMTP_TLS",
         "SMTP_HOST",
         "EMAIL_FROM",
         "SMTP_USERNAME",
@@ -845,10 +832,12 @@ def getConfig():
 
 if __name__ == "__main__":
     config = getConfig()
+
     if "SCRIPT_NAME" in os.environ:
         print(serveRequest(config, sys.stdin.read()))
     else:
         period = sys.argv[1] if len(sys.argv) > 1 else None
         if "DEBUG" in os.environ:
             sys.stdout.write(json.dumps(config))
-        sendDigest(config, period)
+        else:
+            sendDigest(config, period)

Perhaps just server.starttls() can be called optionally if SMTP_TLS is set?

I know technically that SMTP should have a ehlo handshake, but I suspect something has changed in recent python versions.