remove deprecated dependencies

Author: Thomas Desveaux

app/config.go

@@ -3,11 +3,12 @@ package app
 import (
 	"errors"
 	"fmt"
+	"os"
+	"path/filepath"
+
 	"github.com/fsnotify/fsnotify"
 	log "github.com/sirupsen/logrus"
 	"github.com/spf13/viper"
-	"os"
-	"path/filepath"
 )
 
 // Config represents the configuration of the server application.
@@ -111,7 +112,7 @@ func setDefaults() {
 
 // AuthenticationNeeded returns whether users are defined and authentication is required
 func (cfg *Config) AuthenticationNeeded() bool {
-	return cfg.Users != nil && len(cfg.Users) != 0
+	return len(cfg.Users) != 0
 }
 
 func (cfg *Config) handleConfigUpdate(e fsnotify.Event) {

app/config_test.go

@@ -3,7 +3,6 @@ package app
 import (
 	"bytes"
 	"encoding/json"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"reflect"
@@ -61,7 +60,7 @@ log:
   error: true
 `)
 
-	err := ioutil.WriteFile(filepath.Join(tmpDir, "config.yaml"), yamlCfg, 0600)
+	err := os.WriteFile(filepath.Join(tmpDir, "config.yaml"), yamlCfg, 0600)
 	if err != nil {
 		t.Errorf("error writing test config. error = %v", err)
 	}

app/fs.go

@@ -2,12 +2,13 @@ package app
 
 import (
 	"context"
-	log "github.com/sirupsen/logrus"
-	"golang.org/x/net/webdav"
 	"os"
 	"path"
 	"path/filepath"
 	"strings"
+
+	log "github.com/sirupsen/logrus"
+	"golang.org/x/net/webdav"
 )
 
 // This file is an extension of golang.org/x/net/webdav/file.go.
@@ -32,7 +33,7 @@ func (d Dir) resolveUser(ctx context.Context) string {
 // achieved during the process, the BaseDir is used
 func (d Dir) resolve(ctx context.Context, name string) string {
 	// This implementation is based on Dir.Open's code in the standard net/http package.
-	if filepath.Separator != '/' && strings.IndexRune(name, filepath.Separator) >= 0 ||
+	if filepath.Separator != '/' && strings.ContainsRune(name, filepath.Separator) ||
 		strings.Contains(name, "\x00") {
 		return ""
 	}

cmd/davecli/subcmd/passwd.go

@@ -2,11 +2,12 @@ package subcmd
 
 import (
 	"fmt"
-	"github.com/micromata/dave/app"
-	"github.com/spf13/cobra"
-	"golang.org/x/crypto/ssh/terminal"
 	"os"
 	"syscall"
+
+	"github.com/micromata/dave/app"
+	"github.com/spf13/cobra"
+	"golang.org/x/term"
 )
 
 var passwdCmd = &cobra.Command{
@@ -30,7 +31,7 @@ var passwdCmd = &cobra.Command{
 
 func readPassword() []byte {
 	fmt.Print("Enter password: ")
-	pw, err := terminal.ReadPassword(int(syscall.Stdin))
+	pw, err := term.ReadPassword(int(syscall.Stdin))
 	if err != nil {
 		fmt.Printf("An error occurred reading the password: %s\n", err)
 		os.Exit(1)

go.mod

@@ -10,6 +10,7 @@ require (
 	github.com/spf13/viper v1.20.1
 	golang.org/x/crypto v0.37.0
 	golang.org/x/net v0.39.0
+	golang.org/x/term v0.31.0
 )
 
 require (
@@ -24,7 +25,6 @@ require (
 	github.com/subosito/gotenv v1.6.0 // indirect
 	go.uber.org/multierr v1.11.0 // indirect
 	golang.org/x/sys v0.32.0 // indirect
-	golang.org/x/term v0.31.0 // indirect
 	golang.org/x/text v0.24.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )