docs(ffi_string): fix ignored doctest with working example

Author: 1313

examples/05_screenshot.rs

@@ -53,7 +53,6 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let file = std::fs::File::create(filename)?;
     let buf_writer = std::io::BufWriter::new(file);
-    #[allow(clippy::cast_possible_truncation)]
     let mut encoder = png::Encoder::new(buf_writer, width as u32, height as u32);
     encoder.set_color(png::ColorType::Rgba);
     encoder.set_depth(png::BitDepth::Eight);

src/output/iosurface.rs

@@ -194,12 +194,6 @@ impl IOSurface {
         }
     }
 
-    /// Get the raw pointer
-    #[allow(dead_code)]
-    pub(crate) const fn as_ptr(&self) -> *const c_void {
-        self.0
-    }
-
     /// Get the width of the IOSurface in pixels
     pub fn width(&self) -> usize {
         // FFI returns isize but dimensions are always positive

src/output/sc_stream_frame_info.rs

@@ -173,8 +173,6 @@ mod internal {
     /// # Panics
     ///
     /// Panics if .
-    ///
-    #[allow(clippy::needless_pass_by_value)]
     fn dict_to_cg_rect(cf_rect_raw: CFDictionary) -> CGRect {
         let cf_rect = unsafe {
             CFDictionary::<CFString, CFNumber>::wrap_under_get_rule(

src/screenshot_manager.rs

@@ -64,9 +64,8 @@ extern "C" fn buffer_callback(
 /// # fn example() -> Result<(), Box<dyn std::error::Error>> {
 /// let content = SCShareableContent::get()?;
 /// let display = &content.displays()[0];
-/// # #[allow(deprecated)]
-/// let filter = SCContentFilter::new().with_display_excluding_windows(display, &[]);
-/// let config = SCStreamConfiguration::new();
+/// let filter = SCContentFilter::build().display(display).exclude_windows(&[]).build();
+/// let config = SCStreamConfiguration::build();
 ///
 /// let image = SCScreenshotManager::capture_image(&filter, &config)?;
 /// println!("Screenshot size: {}x{}", image.width(), image.height());
@@ -93,9 +92,8 @@ impl CGImage {
     /// # fn example() -> Result<(), Box<dyn std::error::Error>> {
     /// # let content = SCShareableContent::get()?;
     /// # let display = &content.displays()[0];
-    /// # #[allow(deprecated)]
-    /// # let filter = SCContentFilter::new().with_display_excluding_windows(display, &[]);
-    /// # let config = SCStreamConfiguration::new();
+    /// # let filter = SCContentFilter::build().display(display).exclude_windows(&[]).build();
+    /// # let config = SCStreamConfiguration::build();
     /// let image = SCScreenshotManager::capture_image(&filter, &config)?;
     /// let width = image.width();
     /// println!("Width: {}", width);
@@ -182,9 +180,8 @@ unsafe impl Sync for CGImage {}
 /// # fn example() -> Result<(), Box<dyn std::error::Error>> {
 /// let content = SCShareableContent::get()?;
 /// let display = &content.displays()[0];
-/// # #[allow(deprecated)]
-/// let filter = SCContentFilter::new().with_display_excluding_windows(display, &[]);
-/// let config = SCStreamConfiguration::new()
+/// let filter = SCContentFilter::build().display(display).exclude_windows(&[]).build();
+/// let config = SCStreamConfiguration::build()
 ///     .set_width(1920)?
 ///     .set_height(1080)?;
 ///

src/stream/configuration/mod.rs

@@ -10,7 +10,6 @@ pub mod pixel_format;
 pub mod stream_properties;
 pub mod types;
 
-#[allow(clippy::module_name_repetitions)]
 pub use advanced::SCPresenterOverlayAlertSetting;
 pub use internal::SCStreamConfiguration;
 pub use pixel_format::PixelFormat;
@@ -34,23 +33,6 @@ impl SCStreamConfiguration {
     pub fn build() -> Self {
         Self::internal_init()
     }
-
-    /// Creates a new stream configuration (deprecated - use build())
-    /// 
-    /// # Deprecated
-    /// Use `SCStreamConfiguration::build()` instead:
-    /// ```rust
-    /// use screencapturekit::stream::configuration::SCStreamConfiguration;
-    /// 
-    /// let config = SCStreamConfiguration::build()
-    ///     .set_width(1920)
-    ///     .unwrap();
-    /// ```
-    #[deprecated(since = "1.0.0", note = "Use SCStreamConfiguration::build() instead")]
-    #[must_use]
-    pub fn new() -> Self {
-        Self::internal_init()
-    }
 }
 
 impl Default for SCStreamConfiguration {

src/stream/content_filter.rs

@@ -103,198 +103,6 @@ impl SCContentFilter {
         SCContentFilterBuilder::new()
     }
 
-    /// Creates a new content filter (deprecated - use builder pattern)
-    /// 
-    /// # Deprecated
-    /// Use the builder pattern instead:
-    /// ```no_run
-    /// # use screencapturekit::prelude::*;
-    /// # fn example() -> Result<(), Box<dyn std::error::Error>> {
-    /// # let content = SCShareableContent::get()?;
-    /// # let display = &content.displays()[0];
-    /// let filter = SCContentFilter::build()
-    ///     .display(display)
-    ///     .exclude_windows(&[])
-    ///     .build();
-    /// # Ok(())
-    /// # }
-    /// ```
-    #[deprecated(since = "1.0.0", note = "Use SCContentFilter::build() instead")]
-    #[must_use]
-    pub fn new() -> Self {
-        Self(std::ptr::null())
-    }
-
-    /// Creates a content filter with a desktop independent window (deprecated)
-    ///
-    /// # Deprecated
-    /// Use the builder pattern instead:
-    /// ```no_run
-    /// # use screencapturekit::prelude::*;
-    /// # fn example() -> Result<(), Box<dyn std::error::Error>> {
-    /// # let content = SCShareableContent::get()?;
-    /// # let window = &content.windows()[0];
-    /// let filter = SCContentFilter::build()
-    ///     .window(window)
-    ///     .build();
-    /// # Ok(())
-    /// # }
-    /// ```
-    #[deprecated(since = "1.0.0", note = "Use SCContentFilter::build().window().build() instead")]
-    #[must_use]
-    pub fn with_desktop_independent_window(self, window: &SCWindow) -> Self {
-        // Drop the old filter if any
-        if !self.0.is_null() {
-            unsafe { ffi::sc_content_filter_release(self.0); }
-        }
-        std::mem::forget(self); // Prevent double-free
-        
-        unsafe {
-            let filter = ffi::sc_content_filter_create_with_desktop_independent_window(window.as_ptr());
-            Self(filter)
-        }
-    }
-
-    /// Creates a content filter with a display, excluding specific windows (deprecated)
-    ///
-    /// # Deprecated
-    /// Use the builder pattern instead:
-    /// ```no_run
-    /// # use screencapturekit::prelude::*;
-    /// # fn example() -> Result<(), Box<dyn std::error::Error>> {
-    /// # let content = SCShareableContent::get()?;
-    /// # let display = &content.displays()[0];
-    /// # let window = &content.windows()[0];
-    /// // Capture entire display
-    /// let filter = SCContentFilter::build()
-    ///     .display(display)
-    ///     .exclude_windows(&[])
-    ///     .build();
-    ///
-    /// // Or exclude specific windows
-    /// let filter = SCContentFilter::build()
-    ///     .display(display)
-    ///     .exclude_windows(&[window])
-    ///     .build();
-    /// # Ok(())
-    /// # }
-    /// ```
-    #[deprecated(since = "1.0.0", note = "Use SCContentFilter::build().display().exclude_windows().build() instead")]
-    #[must_use]
-    pub fn with_display_excluding_windows(
-        self,
-        display: &SCDisplay,
-        excluding_windows: &[&SCWindow],
-    ) -> Self {
-        // Drop the old filter if any
-        if !self.0.is_null() {
-            unsafe { ffi::sc_content_filter_release(self.0); }
-        }
-        std::mem::forget(self); // Prevent double-free
-        unsafe {
-            let window_ptrs: Vec<*const c_void> = excluding_windows
-                .iter()
-                .map(|w| w.as_ptr())
-                .collect();
-            
-            let filter = if window_ptrs.is_empty() {
-                ffi::sc_content_filter_create_with_display_excluding_windows(
-                    display.as_ptr(),
-                    std::ptr::null(),
-                    0,
-                )
-            } else {
-                // FFI expects isize for array length (Objective-C NSInteger)
-                #[allow(clippy::cast_possible_wrap)]
-                ffi::sc_content_filter_create_with_display_excluding_windows(
-                    display.as_ptr(),
-                    window_ptrs.as_ptr(),
-                    window_ptrs.len() as isize,
-                )
-            };
-            
-            Self(filter)
-        }
-    }
-
-    /// Creates a content filter with a display, including specific windows (deprecated)
-    #[deprecated(since = "1.0.0", note = "Use SCContentFilter::build().display().include_windows().build() instead")]
-    #[must_use]
-    pub fn with_display_including_windows(
-        self,
-        display: &SCDisplay,
-        including_windows: &[&SCWindow],
-    ) -> Self {
-        // Drop the old filter if any
-        if !self.0.is_null() {
-            unsafe { ffi::sc_content_filter_release(self.0); }
-        }
-        std::mem::forget(self); // Prevent double-free
-        unsafe {
-            let window_ptrs: Vec<*const c_void> = including_windows
-                .iter()
-                .map(|w| w.as_ptr())
-                .collect();
-            
-            let filter = if window_ptrs.is_empty() {
-                ffi::sc_content_filter_create_with_display_including_windows(
-                    display.as_ptr(),
-                    std::ptr::null(),
-                    0,
-                )
-            } else {
-                // FFI expects isize for array length (Objective-C NSInteger)
-                #[allow(clippy::cast_possible_wrap)]
-                ffi::sc_content_filter_create_with_display_including_windows(
-                    display.as_ptr(),
-                    window_ptrs.as_ptr(),
-                    window_ptrs.len() as isize,
-                )
-            };
-            
-            Self(filter)
-        }
-    }
-
-    /// Creates a content filter with a display, including applications and excepting specific windows (deprecated)
-    #[deprecated(since = "1.0.0", note = "Use SCContentFilter::build().display().include_applications().build() instead")]
-    #[must_use]
-    pub fn with_display_including_applications_excepting_windows(
-        self,
-        display: &SCDisplay,
-        applications: &[&SCRunningApplication],
-        excepting_windows: &[&SCWindow],
-    ) -> Self {
-        // Drop the old filter if any
-        if !self.0.is_null() {
-            unsafe { ffi::sc_content_filter_release(self.0); }
-        }
-        std::mem::forget(self); // Prevent double-free
-        unsafe {
-            let app_ptrs: Vec<*const c_void> = applications
-                .iter()
-                .map(|a| a.as_ptr())
-                .collect();
-            
-            let window_ptrs: Vec<*const c_void> = excepting_windows
-                .iter()
-                .map(|w| w.as_ptr())
-                .collect();
-            
-            // FFI expects isize for array lengths (Objective-C NSInteger)
-            #[allow(clippy::cast_possible_wrap)]
-            let filter = ffi::sc_content_filter_create_with_display_including_applications_excepting_windows(
-                display.as_ptr(),
-                if app_ptrs.is_empty() { std::ptr::null() } else { app_ptrs.as_ptr() },
-                app_ptrs.len() as isize,
-                if window_ptrs.is_empty() { std::ptr::null() } else { window_ptrs.as_ptr() },
-                window_ptrs.len() as isize,
-            );
-            
-            Self(filter)
-        }
-    }
-
     /// Returns the raw pointer to the content filter
     pub(crate) fn as_ptr(&self) -> *const c_void {
         self.0

src/stream/delegate_trait.rs

@@ -31,7 +31,6 @@ use crate::error::SCError;
 ///     }
 /// }
 /// ```
-#[allow(clippy::module_name_repetitions)]
 pub trait SCStreamDelegateTrait: Send {
     /// Called when video effects start
     fn output_video_effect_did_start_for_stream(&self) {}

src/stream/internal/cleanup.rs

@@ -32,7 +32,6 @@ impl Cleanup {
         self.handlers.iter().take_while(|&&x| !x.is_null())
     }
 
-    #[allow(clippy::needless_pass_by_ref_mut)]
     pub fn drop_handlers(&mut self) {
         if self.rc.fetch_sub(1, Ordering::Release) != 1 {
             return;

src/stream/internal/ffi_utils.rs

@@ -9,7 +9,7 @@ macro_rules! declare_trait_wrapper {
             pub fn new(handler: impl $t + 'a) -> Self {
                 Self(Box::into_raw(Box::new(Box::new(handler))))
             }
-            #[allow(dead_code)]
+
             pub fn drop_trait(&self) {
                 unsafe {
                     let _ = Box::from_raw(self.0);

src/stream/internal/stream.rs

@@ -32,7 +32,7 @@ extern "C" {
 }
 
 pub type SCStreamRef = *mut __SCStreamRef;
-#[allow(clippy::module_name_repetitions)]
+
 pub struct SCStream(SCStreamRef);
 
 impl_TCFType!(SCStream, SCStreamRef, SCStreamGetTypeID);