Skip to content

Regression on doom-molokai magit vc-added highlights #626

Description

@viccuad

What happened?

After updating 13d2377 to b2c0ea0, magit highlights for doom-molokai share the same background and foreground, making the diffs unreadable.

Old, commit, readable no matter if the cursor is inside the diff or not:
old_1
old_2

New commit, unreadable if the cursor is not inside the diff:
new_2
new_1

What did you expect to happen?

Have the same behavior as before (no green background for magit highlights).
Example: doom-monokai-spectre works as expected.

Steps to reproduce

  1. spc g g
  2. scroll to a change in the magit status buffer.
  3. Fail to read the change.

System Information

  • Emacs version: 27.1
  • Emacs distro: Doom Emacs
  • Operating system: Debian Bullseye
  • Installed commit of doom-themes: b2c0ea0
  • Which theme are you using: doom-molokai

Metadata

Metadata

Assignees

No one assigned

    Labels

    is:facesPertains to extending/improving support for Emacs or plugin facestheme:molokai

    Type

    Fields

    Open to PRs

    None yet

    Priority

    None yet

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions