Skip to content

Commit 8ae9b1a

Browse files
authored
Merge pull request #84 from dopry/chore/streamline-playwright-install
chore: streamline playwright install with container
2 parents 45412f0 + 4e75141 commit 8ae9b1a

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,15 @@ jobs:
4747
- name: Build
4848
run: npm run build
4949

50-
- name: playwright install, required for e2e tests
51-
run: npx playwright install chromium --with-deps
50+
# this is not needed when using the playwright container; it has browsers pre-installed
51+
# - name: playwright install, required for e2e tests
52+
# run: npx playwright install chromium --with-deps
5253

5354
- name: E2E Tests
54-
run: npm run test:e2e
55+
uses: docker://mcr.microsoft.com/playwright:v1.56.1-noble
56+
with:
57+
args: npm run test:e2e
58+
5559

5660
# release does a second build due to the prepublishOnly script.
5761
# that's okay we want that to happen to prevent publishing stale local builds.

0 commit comments

Comments
 (0)