Systems being notified when component is added or removed

eduardodoria · eduardodoria · commit 2791553cf61d · 2025-06-21T23:45:53.000-03:00
diff --git a/engine/core/Scene.cpp b/engine/core/Scene.cpp
@@ -252,9 +252,13 @@ bool Scene::isEntityCreated(Entity entity){
 }
 
 void Scene::destroyEntity(Entity entity){
-
+	Signature signature = entityManager.getSignature(entity);
 	for (auto const& pair : systems){
-		pair.second->entityDestroyed(entity);
+		for (ComponentId componentId = 0; componentId < signature.size(); ++componentId) {
+			if (signature.test(componentId)) {
+				pair.second->onComponentRemoved(entity, componentId);
+			}
+		}
 	}
 
 	componentManager.entityDestroyed(entity);
diff --git a/engine/core/Scene.h b/engine/core/Scene.h
@@ -164,10 +164,20 @@ namespace Supernova{
 			auto signature = entityManager.getSignature(entity);
 			signature.set(componentManager.getComponentId<T>(), true);
 			entityManager.setSignature(entity, signature);
+
+			ComponentId componentId = componentManager.getComponentId<T>();
+			for (auto const& pair : systems){
+				pair.second->onComponentAdded(entity, componentId);
+			}
 		}
 
 		template<typename T>
 		void removeComponent(Entity entity){
+			ComponentId componentId = componentManager.getComponentId<T>();
+			for (auto const& pair : systems){
+				pair.second->onComponentRemoved(entity, componentId);
+			}
+
 			componentManager.removeComponent<T>(entity);
 			auto signature = entityManager.getSignature(entity);
 			signature.set(componentManager.getComponentId<T>(), false);
diff --git a/engine/core/component/TextComponent.h b/engine/core/component/TextComponent.h
@@ -31,7 +31,7 @@ namespace Supernova{
 
         std::shared_ptr<STBText> stbtext = NULL;
 
-        bool needReload = false;
+        bool needReloadAtlas = false;
         bool needUpdateText = true;
     };
 
diff --git a/engine/core/ecs/SubSystem.h b/engine/core/ecs/SubSystem.h
@@ -1,5 +1,5 @@
 //
-// (c) 2024 Eduardo Doria.
+// (c) 2025 Eduardo Doria.
 //
 
 #ifndef SUBSYSTEM_H
@@ -8,6 +8,7 @@
 #include "Export.h"
 #include "Entity.h"
 #include "Signature.h"
+#include "ComponentManager.h"
 #include <set>
 
 namespace Supernova{
@@ -34,7 +35,8 @@ namespace Supernova{
 	
 		virtual void update(double dt) = 0;
 
-		virtual void entityDestroyed(Entity entity) = 0;
+		virtual void onComponentAdded(Entity entity, ComponentId componentId) {}
+		virtual void onComponentRemoved(Entity entity, ComponentId componentId) {}
 	
 	};
 
diff --git a/engine/core/object/ui/Button.cpp b/engine/core/object/ui/Button.cpp
@@ -11,9 +11,6 @@ using namespace Supernova;
 
 Button::Button(Scene* scene): Image(scene){
     addComponent<ButtonComponent>({});
-
-    ButtonComponent& btcomp = getComponent<ButtonComponent>();
-    scene->getSystem<UISystem>()->createButtonObjects(entity, btcomp);
 }
 
 Button::Button(Scene* scene, Entity entity): Image(scene, entity){
diff --git a/engine/core/object/ui/Panel.cpp b/engine/core/object/ui/Panel.cpp
@@ -11,9 +11,6 @@ using namespace Supernova;
 
 Panel::Panel(Scene* scene): Image(scene){
     addComponent<PanelComponent>({});
-
-    PanelComponent& panelcomp = getComponent<PanelComponent>();
-    scene->getSystem<UISystem>()->createPanelObjects(entity, panelcomp);
 }
 
 Panel::Panel(Scene* scene, Entity entity): Image(scene, entity){
diff --git a/engine/core/object/ui/Scrollbar.cpp b/engine/core/object/ui/Scrollbar.cpp
@@ -10,9 +10,6 @@ using namespace Supernova;
 
 Scrollbar::Scrollbar(Scene* scene): Image(scene){
     addComponent<ScrollbarComponent>({});
-
-    ScrollbarComponent& scrollcomp = getComponent<ScrollbarComponent>();
-    scene->getSystem<UISystem>()->createScrollbarObjects(entity, scrollcomp);
 }
 
 Scrollbar::Scrollbar(Scene* scene, Entity entity): Image(scene, entity){
diff --git a/engine/core/object/ui/Text.cpp b/engine/core/object/ui/Text.cpp
@@ -74,7 +74,7 @@ void Text::setMaxTextSize(unsigned int maxTextSize){
     if (textcomp.maxTextSize != maxTextSize){
         textcomp.maxTextSize = maxTextSize;
 
-        textcomp.needReload = true;
+        textcomp.needReloadAtlas = true;
         textcomp.needUpdateText = true;
         ui.needReload = true;
     }
@@ -107,7 +107,7 @@ void Text::setFont(const std::string &font){
     if (textcomp.font != font){
         textcomp.font = font;
 
-        textcomp.needReload = true;
+        textcomp.needReloadAtlas = true;
         textcomp.needUpdateText = true;
     }
 }
@@ -123,7 +123,7 @@ void Text::setFontSize(unsigned int fontSize){
 
     textcomp.fontSize = fontSize;
 
-    textcomp.needReload = true;
+    textcomp.needReloadAtlas = true;
     textcomp.needUpdateText = true;
 }
 
diff --git a/engine/core/object/ui/TextEdit.cpp b/engine/core/object/ui/TextEdit.cpp
@@ -11,9 +11,6 @@ using namespace Supernova;
 
 TextEdit::TextEdit(Scene* scene): Image(scene){
     addComponent<TextEditComponent>({});
-
-    TextEditComponent& tecomp = getComponent<TextEditComponent>();
-    scene->getSystem<UISystem>()->createTextEditObjects(entity, tecomp);
 }
 
 TextEdit::TextEdit(Scene* scene, Entity entity): Image(scene, entity){
diff --git a/engine/core/subsystem/ActionSystem.cpp b/engine/core/subsystem/ActionSystem.cpp
@@ -1,5 +1,5 @@
 //
-// (c) 2024 Eduardo Doria.
+// (c) 2025 Eduardo Doria.
 //
 
 #include "ActionSystem.h"
@@ -1117,14 +1117,16 @@ void ActionSystem::update(double dt){
 	}
 }
 
-void ActionSystem::entityDestroyed(Entity entity){
-    Signature signature = scene->getSignature(entity);
+void ActionSystem::onComponentAdded(Entity entity, ComponentId componentId) {
 
-    if (signature.test(scene->getComponentId<ActionComponent>())){
-        actionDestroy(scene->getComponent<ActionComponent>(entity));
-    }
+}
 
-    if (signature.test(scene->getComponentId<AnimationComponent>())){
-        animationDestroy(scene->getComponent<AnimationComponent>(entity));
-    }
+void ActionSystem::onComponentRemoved(Entity entity, ComponentId componentId) {
+	if (componentId == scene->getComponentId<ActionComponent>()) {
+		ActionComponent& action = scene->getComponent<ActionComponent>(entity);
+		actionDestroy(action);
+	} else if (componentId == scene->getComponentId<AnimationComponent>()) {
+		AnimationComponent& animation = scene->getComponent<AnimationComponent>(entity);
+		animationDestroy(animation);
+	}
 }
diff --git a/engine/core/subsystem/ActionSystem.h b/engine/core/subsystem/ActionSystem.h
@@ -1,5 +1,5 @@
 //
-// (c) 2024 Eduardo Doria.
+// (c) 2025 Eduardo Doria.
 //
 
 #ifndef ACTIONSYSTEM_H
@@ -110,7 +110,8 @@ namespace Supernova{
 		virtual void update(double dt);
 		virtual void draw();
 
-		virtual void entityDestroyed(Entity entity);
+		virtual void onComponentAdded(Entity entity, ComponentId componentId) override;
+		virtual void onComponentRemoved(Entity entity, ComponentId componentId) override;
 	};
 
 }
diff --git a/engine/core/subsystem/AudioSystem.cpp b/engine/core/subsystem/AudioSystem.cpp
@@ -1,5 +1,5 @@
 //
-// (c) 2024 Eduardo Doria.
+// (c) 2025 Eduardo Doria.
 //
 
 #include "AudioSystem.h"
@@ -273,12 +273,13 @@ void AudioSystem::draw(){
 
 }
 
-void AudioSystem::entityDestroyed(Entity entity){
-    Signature signature = scene->getSignature(entity);
+void AudioSystem::onComponentAdded(Entity entity, ComponentId componentId) {
 
-    if (signature.test(scene->getComponentId<AudioComponent>())){
-        AudioComponent& audio = scene->getComponent<AudioComponent>(entity);
+}
 
-        destroyAudio(audio);
-    }
+void AudioSystem::onComponentRemoved(Entity entity, ComponentId componentId) {
+	if (componentId == scene->getComponentId<AudioComponent>()) {
+		AudioComponent& audio = scene->getComponent<AudioComponent>(entity);
+		destroyAudio(audio);
+	}
 }
diff --git a/engine/core/subsystem/AudioSystem.h b/engine/core/subsystem/AudioSystem.h
@@ -1,5 +1,5 @@
 //
-// (c) 2024 Eduardo Doria.
+// (c) 2025 Eduardo Doria.
 //
 
 #ifndef AUDIOSYSTEM_H
@@ -48,7 +48,8 @@ namespace Supernova{
         virtual void update(double dt);
 		virtual void draw();
 
-		virtual void entityDestroyed(Entity entity);
+		virtual void onComponentAdded(Entity entity, ComponentId componentId) override;
+		virtual void onComponentRemoved(Entity entity, ComponentId componentId) override;
 	};
 
 }
diff --git a/engine/core/subsystem/MeshSystem.cpp b/engine/core/subsystem/MeshSystem.cpp
@@ -1,5 +1,5 @@
 //
-// (c) 2024 Eduardo Doria.
+// (c) 2025 Eduardo Doria.
 //
 
 #include "MeshSystem.h"
@@ -2747,10 +2747,13 @@ void MeshSystem::draw(){
 
 }
 
-void MeshSystem::entityDestroyed(Entity entity){
-	Signature signature = scene->getSignature(entity);
+void MeshSystem::onComponentAdded(Entity entity, ComponentId componentId) {
 
-	if (signature.test(scene->getComponentId<ModelComponent>())){
-        destroyModel(scene->getComponent<ModelComponent>(entity));
+}
+
+void MeshSystem::onComponentRemoved(Entity entity, ComponentId componentId) {
+	if (componentId == scene->getComponentId<ModelComponent>()) {
+		ModelComponent& model = scene->getComponent<ModelComponent>(entity);
+		destroyModel(model);
 	}
 }
diff --git a/engine/core/subsystem/MeshSystem.h b/engine/core/subsystem/MeshSystem.h
@@ -1,5 +1,5 @@
 //
-// (c) 2024 Eduardo Doria.
+// (c) 2025 Eduardo Doria.
 //
 
 #ifndef MESHSYSTEM_H
@@ -88,7 +88,8 @@ namespace Supernova{
         virtual void update(double dt);
 		virtual void draw();
 
-		virtual void entityDestroyed(Entity entity);
+		virtual void onComponentAdded(Entity entity, ComponentId componentId) override;
+		virtual void onComponentRemoved(Entity entity, ComponentId componentId) override;
 	};
 
 }
diff --git a/engine/core/subsystem/PhysicsSystem.cpp b/engine/core/subsystem/PhysicsSystem.cpp
@@ -1,5 +1,5 @@
 //
-// (c) 2024 Eduardo Doria.
+// (c) 2025 Eduardo Doria.
 //
 
 #include "PhysicsSystem.h"
@@ -1923,19 +1923,22 @@ void PhysicsSystem::draw(){
 
 }
 
-void PhysicsSystem::entityDestroyed(Entity entity){
-    Signature signature = scene->getSignature(entity);
+void PhysicsSystem::onComponentAdded(Entity entity, ComponentId componentId) {
 
-    if (signature.test(scene->getComponentId<Body2DComponent>())){
-        destroyBody2D(scene->getComponent<Body2DComponent>(entity));
-    }
-    if (signature.test(scene->getComponentId<Body3DComponent>())){
-        destroyBody3D(scene->getComponent<Body3DComponent>(entity));
-    }
-    if (signature.test(scene->getComponentId<Joint2DComponent>())){
-        destroyJoint2D(scene->getComponent<Joint2DComponent>(entity));
-    }
-    if (signature.test(scene->getComponentId<Joint3DComponent>())){
-        destroyJoint3D(scene->getComponent<Joint3DComponent>(entity));
-    }
 }
+
+void PhysicsSystem::onComponentRemoved(Entity entity, ComponentId componentId) {
+	if (componentId == scene->getComponentId<Body2DComponent>()) {
+		Body2DComponent& body2d = scene->getComponent<Body2DComponent>(entity);
+		destroyBody2D(body2d);
+	} else if (componentId == scene->getComponentId<Body3DComponent>()) {
+		Body3DComponent& body3d = scene->getComponent<Body3DComponent>(entity);
+		destroyBody3D(body3d);
+	} else if (componentId == scene->getComponentId<Joint2DComponent>()) {
+		Joint2DComponent& joint2d = scene->getComponent<Joint2DComponent>(entity);
+		destroyJoint2D(joint2d);
+	} else if (componentId == scene->getComponentId<Joint3DComponent>()) {
+		Joint3DComponent& joint3d = scene->getComponent<Joint3DComponent>(entity);
+		destroyJoint3D(joint3d);
+	}
+}
diff --git a/engine/core/subsystem/PhysicsSystem.h b/engine/core/subsystem/PhysicsSystem.h
@@ -1,5 +1,5 @@
 //
-// (c) 2024 Eduardo Doria.
+// (c) 2025 Eduardo Doria.
 //
 
 #ifndef PHYSICSSYSTEM_H
@@ -165,7 +165,8 @@ namespace Supernova{
 		virtual void update(double dt);
 		virtual void draw();
 
-		virtual void entityDestroyed(Entity entity);
+		virtual void onComponentAdded(Entity entity, ComponentId componentId) override;
+		virtual void onComponentRemoved(Entity entity, ComponentId componentId) override;
 	};
 
 }
diff --git a/engine/core/subsystem/RenderSystem.cpp b/engine/core/subsystem/RenderSystem.cpp
diff --git a/engine/core/subsystem/RenderSystem.h b/engine/core/subsystem/RenderSystem.h
diff --git a/engine/core/subsystem/UISystem.cpp b/engine/core/subsystem/UISystem.cpp
diff --git a/engine/core/subsystem/UISystem.h b/engine/core/subsystem/UISystem.h

Original file line number	Diff line number	Diff line change
`@@ -252,9 +252,13 @@ bool Scene::isEntityCreated(Entity entity){`
`252`	`252`	`}`
`253`	`253`
`254`	`254`	`void Scene::destroyEntity(Entity entity){`
`255`		`-`
	`255`	`+ Signature signature = entityManager.getSignature(entity);`
`256`	`256`	`for (auto const& pair : systems){`
`257`		`- pair.second->entityDestroyed(entity);`
	`257`	`+ for (ComponentId componentId = 0; componentId < signature.size(); ++componentId) {`
	`258`	`+ if (signature.test(componentId)) {`
	`259`	`+ pair.second->onComponentRemoved(entity, componentId);`
	`260`	`+ }`
	`261`	`+ }`
`258`	`262`	`}`
`259`	`263`
`260`	`264`	`componentManager.entityDestroyed(entity);`
Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,6 @@ using namespace Supernova;`
`11`	`11`
`12`	`12`	`Button::Button(Scene* scene): Image(scene){`
`13`	`13`	`addComponent<ButtonComponent>({});`
`14`		`-`
`15`		`- ButtonComponent& btcomp = getComponent<ButtonComponent>();`
`16`		`- scene->getSystem<UISystem>()->createButtonObjects(entity, btcomp);`
`17`	`14`	`}`
`18`	`15`
`19`	`16`	`Button::Button(Scene* scene, Entity entity): Image(scene, entity){`
Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,6 @@ using namespace Supernova;`
`10`	`10`
`11`	`11`	`Scrollbar::Scrollbar(Scene* scene): Image(scene){`
`12`	`12`	`addComponent<ScrollbarComponent>({});`
`13`		`-`
`14`		`- ScrollbarComponent& scrollcomp = getComponent<ScrollbarComponent>();`
`15`		`- scene->getSystem<UISystem>()->createScrollbarObjects(entity, scrollcomp);`
`16`	`13`	`}`
`17`	`14`
`18`	`15`	`Scrollbar::Scrollbar(Scene* scene, Entity entity): Image(scene, entity){`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ void Text::setMaxTextSize(unsigned int maxTextSize){`
`74`	`74`	`if (textcomp.maxTextSize != maxTextSize){`
`75`	`75`	`textcomp.maxTextSize = maxTextSize;`
`76`	`76`
`77`		`- textcomp.needReload = true;`
	`77`	`+ textcomp.needReloadAtlas = true;`
`78`	`78`	`textcomp.needUpdateText = true;`
`79`	`79`	`ui.needReload = true;`
`80`	`80`	`}`
`@@ -107,7 +107,7 @@ void Text::setFont(const std::string &font){`
`107`	`107`	`if (textcomp.font != font){`
`108`	`108`	`textcomp.font = font;`
`109`	`109`
`110`		`- textcomp.needReload = true;`
	`110`	`+ textcomp.needReloadAtlas = true;`
`111`	`111`	`textcomp.needUpdateText = true;`
`112`	`112`	`}`
`113`	`113`	`}`
`@@ -123,7 +123,7 @@ void Text::setFontSize(unsigned int fontSize){`
`123`	`123`
`124`	`124`	`textcomp.fontSize = fontSize;`
`125`	`125`
`126`		`- textcomp.needReload = true;`
	`126`	`+ textcomp.needReloadAtlas = true;`
`127`	`127`	`textcomp.needUpdateText = true;`
`128`	`128`	`}`
`129`	`129`