fix(windows): add windowsHide to all child_process calls

Extend windowsHide: true to git, shell detection, agent detection,
version check, and update executor modules. The initial fix only
covered tunnel and service modules but git commands (polled by the
frontend) were the main source of flashing console windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: dorlugasigal

src/cli/index.js

@@ -79,7 +79,7 @@ function getWindowsAncestors(startPid, maxDepth = 4) {
     const result = execFileSync(
       'wmic',
       ['process', 'get', 'Name,ParentProcessId,ProcessId', '/format:csv'],
-      { stdio: ['pipe', 'pipe', 'ignore'], encoding: 'utf8', timeout: 5000 },
+      { stdio: ['pipe', 'pipe', 'ignore'], encoding: 'utf8', timeout: 5000, windowsHide: true },
     );
 
     // Parse CSV output — first non-empty line is the header

src/utils/agents.js

@@ -62,24 +62,29 @@ function tryDetectAgent(agent) {
     let remaining = candidates.length;
 
     for (const bin of candidates) {
-      child_process.execFile(bin, args, { timeout: 5000, encoding: 'utf8' }, (err, stdout) => {
-        remaining--;
-        if (resolved) return;
-        if (!err) {
-          resolved = true;
-          const version = (stdout || '').trim().split('\n')[0] || 'unknown';
-          resolve({
-            id: agent.id,
-            name: agent.name,
-            cmd: agent.cmd,
-            args: agent.args || [],
-            icon: agent.icon,
-            version,
-          });
-        } else if (remaining === 0) {
-          resolve(null);
-        }
-      });
+      child_process.execFile(
+        bin,
+        args,
+        { timeout: 5000, encoding: 'utf8', windowsHide: true },
+        (err, stdout) => {
+          remaining--;
+          if (resolved) return;
+          if (!err) {
+            resolved = true;
+            const version = (stdout || '').trim().split('\n')[0] || 'unknown';
+            resolve({
+              id: agent.id,
+              name: agent.name,
+              cmd: agent.cmd,
+              args: agent.args || [],
+              icon: agent.icon,
+              version,
+            });
+          } else if (remaining === 0) {
+            resolve(null);
+          }
+        },
+      );
     }
   });
 }

src/utils/git.js

@@ -3,7 +3,9 @@ const path = require('path');
 const log = require('./logger');
 
 function git(cmd, cwd) {
-  return execSync(`git ${cmd}`, { cwd, stdio: 'pipe', timeout: 3000 }).toString().trim();
+  return execSync(`git ${cmd}`, { cwd, stdio: 'pipe', timeout: 3000, windowsHide: true })
+    .toString()
+    .trim();
 }
 
 function getGitInfo(cwd) {
@@ -144,7 +146,7 @@ async function getGitRoot(cwd) {
       require('child_process').execFile(
         'git',
         ['rev-parse', '--show-toplevel'],
-        { cwd, timeout: GIT_TIMEOUT },
+        { cwd, timeout: GIT_TIMEOUT, windowsHide: true },
         (err, stdout) => {
           if (err) return reject(err);
           resolve(stdout.trim());
@@ -167,6 +169,7 @@ async function gitAsync(args, cwd, options = {}) {
         cwd,
         timeout: options.timeout || GIT_TIMEOUT,
         maxBuffer: options.maxBuffer || MAX_DIFF_BUFFER,
+        windowsHide: true,
       },
       (err, stdout) => {
         if (err) return reject(err);
@@ -343,6 +346,7 @@ async function getFileDiff(cwd, filePath, options = {}) {
             cwd: root,
             timeout: GIT_TIMEOUT,
             maxBuffer: MAX_DIFF_BUFFER,
+            windowsHide: true,
           },
           (err, stdout) => {
             // git diff --no-index exits with 1 when files differ — that's expected

src/utils/shells.js

@@ -25,6 +25,7 @@ function detectWindowsShells() {
         stdio: ['pipe', 'pipe', 'ignore'],
         encoding: 'utf8',
         timeout: 3000,
+        windowsHide: true,
       });
       const fullPath = result.trim().split('\n')[0].trim();
       if (fullPath) {

src/utils/update-executor.js

@@ -339,15 +339,20 @@ function clearUpdateResult() {
 
 function execFilePromise(cmd, args, options = {}) {
   return new Promise((resolve, reject) => {
-    execFile(cmd, args, { encoding: 'utf8', ...options }, (err, stdout, stderr) => {
-      if (err) {
-        err.stdout = stdout;
-        err.stderr = stderr;
-        reject(err);
-      } else {
-        resolve({ stdout, stderr });
-      }
-    });
+    execFile(
+      cmd,
+      args,
+      { encoding: 'utf8', windowsHide: true, ...options },
+      (err, stdout, stderr) => {
+        if (err) {
+          err.stdout = stdout;
+          err.stderr = stderr;
+          reject(err);
+        } else {
+          resolve({ stdout, stderr });
+        }
+      },
+    );
   });
 }
 

src/utils/version.js

@@ -23,6 +23,7 @@ function getVersion() {
       cwd: path.join(__dirname, '..', '..'),
       encoding: 'utf-8',
       stdio: ['pipe', 'pipe', 'pipe'],
+      windowsHide: true,
     }).trim();
 
     const tagMatch = gitDesc.match(/^v(\d+\.\d+\.\d+)(?:-(\d+)-g([0-9a-f]+))?(-dirty)?$/);