Trimmed report fails to write to action summary

[byron-goldsack]

Describe the bug

When using the action in a run which has a large number of test cases, the trimming functionality appears cause the action to fail to write anything to action summary.

"Test report summary exceeded limit of 1048576 bytes and will be trimmed"

Viewing the step logs, markdown content has been generated, but not written to the summary page.

Unclear if this is related to having multiple test result files using wildcard for the path input, or simply a large number of failing tests.

To Reproduce

Our usage:

      - name: Generate Test Summary
          uses: dorny/test-reporter@v2.1.1
          with:
            name: Test Summary
            path: 'C:\Temp\SampleTestResults\*.trx'
            reporter: dotnet-trx
            path-replace-backslashes: true
            fail-on-error: false
            fail-on-empty: false
            list-suites: none
            list-tests: failed

The Trx files tested on have 6722 passed, 1880 failed, and 100 skipped

When testing with a much larger test suite (~40k, unknown number of failures):

Expected behavior

The summary page should correctly display the trimmed content
Alternatively
The action should fall back to summary-only: true

Screenshots

[whois-jon-peterson]

This is likely a result of changes introduced in #589

getReport/trimReport attempt to keep the summary under the byte threshold, however 589 added a "shortSummary" line (35+ bytes) to the beginning of the summary after that overflow check has happened.

test-reporter/src/main.ts

Lines 190 to 191 in 34d8269

	core.summary.addRaw(`# ${shortSummary}`)
	await core.summary.addRaw(summary).write()

[byron-goldsack]

Another possible cause is we have a previous action also adding content to the step summary. I'm not sure if this action expects to be the only source of content for the summary?

[whois-jon-peterson]

Are you maybe using dorny/test-reported in a Composite Action?

Step summary limits should be specific to each Step, however I suspect (the docs are unclear IMO) even though Composite Actions have multiple "steps" internally, they still count together under the Job-level Step that called the Composite Action. I'm reading between the lines of how the limits are phrased and the phrase "... run as a single job step."

If you're using a Composite Action, then yeah the previous Action adding content to the step summary is probably the cause. If not, then I think the previous Action probably a red herring and it suggests my fix branch is incomplete.

[byron-goldsack]

Can confirm, we are using within a composite action. I'll move the usage into a single step action to see if that fixes our issue. I think your fix is probably still valid, just not for the specific case I was seeing.