fix: rename date_recorded back to date_finished for books

date_recorded was a confusing name - it's the date you finished reading
the book, not when it was recorded. Rename to date_finished to match
comics and anime. Clear bogus finish dates on unread books and move the
original shelf-added timestamps into date_added where they belong.

Sort options now hide Date Finished and Date Started when they don't
apply to the current status filter.

Author: dotMavriQ

app/Livewire/Books/BookIndex.php

@@ -45,7 +45,7 @@ private function applyAccentInsensitiveSearch($query, string $search, array $col
 
     public bool $selectAll = false;
 
-    private const ALLOWED_SORT_COLUMNS = ['title', 'author', 'rating', 'page_count', 'date_finished', 'updated_at', 'date_started', 'date_recorded'];
+    private const ALLOWED_SORT_COLUMNS = ['title', 'author', 'rating', 'page_count', 'date_finished', 'date_added', 'updated_at', 'date_started'];
 
     protected $queryString = [
         'search' => ['except' => ''],
@@ -61,8 +61,15 @@ public function updatingSearch(): void
         $this->resetPage();
     }
 
-    public function updatingStatus(): void
+    public function updatingStatus(string $value): void
     {
+        // Reset sort if it no longer applies to the new status
+        if ($value === 'want_to_read' && in_array($this->sortBy, ['date_finished', 'date_started'])) {
+            $this->sortBy = 'date_added';
+        } elseif ($value === 'reading' && $this->sortBy === 'date_finished') {
+            $this->sortBy = 'date_started';
+        }
+
         $this->resetPage();
     }
 

app/Livewire/Dashboard.php

@@ -59,7 +59,7 @@ public function getReadingStats(): array
         $bookStats = $user->books()
             ->selectRaw("COUNT(*) as total")
             ->selectRaw("SUM(CASE WHEN status = ? THEN 1 ELSE 0 END) as currently_reading", [ReadingStatus::Reading->value])
-            ->selectRaw("SUM(CASE WHEN status = ? AND " . sprintf($yearSql, 'date_recorded') . " = ? THEN 1 ELSE 0 END) as read_this_year", [ReadingStatus::Read->value, (string) $year])
+            ->selectRaw("SUM(CASE WHEN status = ? AND " . sprintf($yearSql, 'date_finished') . " = ? THEN 1 ELSE 0 END) as read_this_year", [ReadingStatus::Read->value, (string) $year])
             ->first();
 
         $comicStats = $user->comics()

app/Models/Book.php

@@ -37,7 +37,7 @@ class Book extends Model
         'date_pub',
         'date_pub_edition',
         'date_started',
-        'date_recorded',
+        'date_finished',
         'date_added',
         'shelves',
         'notes',
@@ -61,7 +61,7 @@ protected function casts(): array
             'owned' => 'boolean',
             'published_date' => 'date',
             'date_started' => 'date',
-            'date_recorded' => 'date',
+            'date_finished' => 'date',
             'date_added' => 'date',
         ];
     }

app/Services/GoodReadsImportService.php

@@ -55,7 +55,7 @@ protected function mapRowToBook(array $row): array
             'status' => $this->mapShelfToStatus($row['Exclusive Shelf'] ?? $row['Shelves'] ?? ''),
             'rating' => $this->parseRating($row['My Rating'] ?? ''),
             'date_started' => $this->parseDate($row['Date Started'] ?? ''),
-            'date_recorded' => $this->parseDate($row['Date Read'] ?? ''),
+            'date_finished' => $this->parseDate($row['Date Read'] ?? ''),
             'notes' => $row['My Review'] ?? $row['Review'] ?? null,
             'cover_url' => null,
         ];

database/migrations/2026_03_14_135935_rename_date_recorded_to_date_finished_in_books.php

@@ -0,0 +1,28 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    public function up(): void
+    {
+        // Clear dates for books that aren't "read" -- these are just Goodreads shelf timestamps
+        DB::table('books')
+            ->whereNot('status', 'read')
+            ->update(['date_recorded' => null]);
+
+        Schema::table('books', function (Blueprint $table) {
+            $table->renameColumn('date_recorded', 'date_finished');
+        });
+    }
+
+    public function down(): void
+    {
+        Schema::table('books', function (Blueprint $table) {
+            $table->renameColumn('date_finished', 'date_recorded');
+        });
+    }
+};

resources/views/livewire/books/book-index.blade.php

@@ -109,9 +109,13 @@ class="rounded-md border-0 py-1.5 pl-3 pr-8 text-sm text-theme-text-primary ring
                             </optgroup>
                             <optgroup label="Your Data">
                                 <option value="rating">Your Rating</option>
-                                <option value="date_recorded">Added to Library</option>
-                                <option value="date_started">Date Started</option>
-                                <option value="created_at">Date Added</option>
+                                @if(in_array($status, ['read', 'reading', '']))
+                                    <option value="date_started">Date Started</option>
+                                @endif
+                                @if(in_array($status, ['read', '']))
+                                    <option value="date_finished">Date Finished</option>
+                                @endif
+                                <option value="date_added">Added to Library</option>
                                 <option value="updated_at">Recently Updated</option>
                             </optgroup>
                         </select>

resources/views/livewire/books/book-show.blade.php

@@ -211,10 +211,10 @@ class="btn-danger inline-flex items-center rounded-md px-3 py-2 text-sm font-sem
                             </div>
                         @endif
 
-                        @if($book->date_recorded ?? $book->date_added)
+                        @if($book->date_finished)
                             <div>
-                                <dt class="text-sm font-medium text-theme-text-secondary">Added to Library</dt>
-                                <dd class="mt-1 text-sm text-theme-text-primary">{{ ($book->date_recorded ?? $book->date_added)->format('F j, Y') }}</dd>
+                                <dt class="text-sm font-medium text-theme-text-secondary">Date Finished</dt>
+                                <dd class="mt-1 text-sm text-theme-text-primary">{{ $book->date_finished->format('F j, Y') }}</dd>
                             </div>
                         @endif