fix(lint): resolve golangci-lint errors for CI

- Fix errcheck: suppress git config errors in test setup
- Remove unused code: componentType field, normalizeHeadings,
  trimTrailingWhitespace, parseJSON
- Fix gosimple: use variadic append for toolWarnings
- Fix staticcheck: replace deprecated strings.Title with cases.Title
- Remove unused imports (encoding/json, regexp)

Author: Test User

go.mod

@@ -8,6 +8,7 @@ require (
 	github.com/charmbracelet/lipgloss v1.1.0
 	github.com/spf13/cobra v1.10.2
 	github.com/spf13/viper v1.21.0
+	golang.org/x/text v0.32.0
 	gopkg.in/yaml.v3 v3.0.1
 )
 
@@ -44,7 +45,6 @@ require (
 	golang.org/x/exp v0.0.0-20251219203646-944ab1f22d93 // indirect
 	golang.org/x/net v0.48.0 // indirect
 	golang.org/x/sys v0.39.0 // indirect
-	golang.org/x/text v0.32.0 // indirect
 	golang.org/x/tools v0.40.0 // indirect
 	google.golang.org/protobuf v1.36.11 // indirect
 	gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15 // indirect

internal/cli/agent_linter.go

@@ -51,9 +51,7 @@ func (l *AgentLinter) ValidateSpecific(data map[string]interface{}, filePath, co
 
 	// Validate allowed-tools
 	toolWarnings := ValidateAllowedTools(data, filePath, contents)
-	for _, w := range toolWarnings {
-		errors = append(errors, w)
-	}
+	errors = append(errors, toolWarnings...)
 
 	return errors
 }

internal/cli/command_linter.go

@@ -48,9 +48,7 @@ func (l *CommandLinter) ValidateSpecific(data map[string]interface{}, filePath,
 
 	// Validate allowed-tools
 	toolWarnings := ValidateAllowedTools(data, filePath, contents)
-	for _, w := range toolWarnings {
-		errors = append(errors, w)
-	}
+	errors = append(errors, toolWarnings...)
 
 	return errors
 }

internal/cli/lineutil.go

@@ -6,6 +6,8 @@ import (
 	"strings"
 
 	"github.com/dotcommander/cclint/internal/cue"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
 )
 
 // FindLineNumber finds the line number (1-based) where a pattern first appears
@@ -372,7 +374,7 @@ func ValidateToolFieldName(data map[string]interface{}, filePath string, content
 		if _, hasTools := data["tools"]; hasTools {
 			errors = append(errors, cue.ValidationError{
 				File:     filePath,
-				Message:  fmt.Sprintf("%ss must use 'allowed-tools:', not 'tools:'. Rename the field.", strings.Title(componentType)),
+				Message:  fmt.Sprintf("%ss must use 'allowed-tools:', not 'tools:'. Rename the field.", cases.Title(language.English).String(componentType)),
 				Severity: "error",
 				Source:   cue.SourceCClintObserve,
 				Line:     FindFrontmatterFieldLine(contents, "tools"),

internal/cli/settings.go

@@ -1,7 +1,6 @@
 package cli
 
 import (
-	"encoding/json"
 	"fmt"
 	"regexp"
 	"strings"
@@ -18,11 +17,6 @@ func LintSettings(rootPath string, quiet bool, verbose bool, noCycleCheck bool)
 	return lintBatch(ctx, NewSettingsLinter()), nil
 }
 
-// parseJSON parses JSON content into the provided interface
-func parseJSON(content string, out interface{}) error {
-	return json.Unmarshal([]byte(content), out)
-}
-
 // Valid hook events according to Anthropic documentation
 var validHookEvents = map[string]bool{
 	"PreToolUse":        true,

internal/format/formatter.go

@@ -3,7 +3,6 @@ package format
 import (
 	"bytes"
 	"fmt"
-	"regexp"
 	"sort"
 	"strings"
 
@@ -19,9 +18,7 @@ type Formatter interface {
 }
 
 // ComponentFormatter provides base formatting for all component types.
-type ComponentFormatter struct {
-	componentType string
-}
+type ComponentFormatter struct{}
 
 // NewComponentFormatter creates a formatter for a specific component type.
 func NewComponentFormatter(componentType string) Formatter {
@@ -284,17 +281,3 @@ func Diff(original, formatted, filename string) string {
 
 	return buf.String()
 }
-
-// normalizeHeadings ensures consistent heading levels.
-// This is a placeholder for more sophisticated heading normalization.
-func normalizeHeadings(content string) string {
-	// For now, just return as-is. Future: normalize ## to consistent levels.
-	return content
-}
-
-// trimTrailingWhitespace removes trailing whitespace from lines.
-var trailingWhitespaceRegex = regexp.MustCompile(`[ \t]+$`)
-
-func trimTrailingWhitespace(line string) string {
-	return trailingWhitespaceRegex.ReplaceAllString(line, "")
-}

internal/git/diff_test.go

@@ -215,8 +215,8 @@ func TestGitIntegration(t *testing.T) {
 	}
 
 	// Configure git user (required for commits)
-	exec.Command("git", "config", "user.email", "test@test.com").Run()
-	exec.Command("git", "config", "user.name", "Test User").Run()
+	_ = exec.Command("git", "config", "user.email", "test@test.com").Run()
+	_ = exec.Command("git", "config", "user.name", "Test User").Run()
 
 	// Create test files
 	agentPath := filepath.Join(tmpDir, "agents", "test-agent.md")