feat(linters): wire tool field name validation into all component linters

Integrates ValidateToolFieldName() checks into agent, command, and skill linters:

- agents.go: Validates agents use 'tools:' not 'allowed-tools:'
- commands.go: Validates commands use 'allowed-tools:' not 'tools:'
- skills.go: Validates skills use 'allowed-tools:' not 'tools:'
- singlefile.go: Properly handles error severity in skill validation

Fixes skills.go and singlefile.go to separate errors from suggestions based
on severity field, ensuring tool naming violations are reported as errors.

This enforces Anthropic's documented field naming conventions across all
component types at lint time.

Author: garyblankenship

internal/cli/agents.go

@@ -238,6 +238,9 @@ func validateAgentSpecific(data map[string]interface{}, filePath string, content
 		}
 	}
 
+	// Validate tool field naming (agents use 'tools:', not 'allowed-tools:')
+	errors = append(errors, ValidateToolFieldName(data, filePath, contents, "agent")...)
+
 	// Best practice checks
 	errors = append(errors, validateAgentBestPractices(filePath, contents, data)...)
 

internal/cli/commands.go

@@ -129,6 +129,9 @@ func validateCommandSpecific(data map[string]interface{}, filePath string, conte
 		}
 	}
 
+	// Validate tool field naming (commands use 'allowed-tools:', not 'tools:')
+	errors = append(errors, ValidateToolFieldName(data, filePath, contents, "command")...)
+
 	return errors
 }
 

internal/cli/singlefile.go

@@ -530,8 +530,15 @@ func lintSingleSkill(ctx *SingleFileLinterContext) LintResult {
 	}
 
 	// Best practice checks
-	suggestions := validateSkillBestPractices(ctx.File.RelPath, ctx.File.Contents, fmData)
-	result.Suggestions = append(result.Suggestions, suggestions...)
+	allResults := validateSkillBestPractices(ctx.File.RelPath, ctx.File.Contents, fmData)
+	// Separate errors from suggestions based on severity
+	for _, r := range allResults {
+		if r.Severity == "error" {
+			result.Errors = append(result.Errors, r)
+		} else {
+			result.Suggestions = append(result.Suggestions, r)
+		}
+	}
 
 	// Cross-file validation (outgoing refs)
 	crossValidator := ctx.EnsureCrossFileValidator()

internal/cli/skills.go

@@ -102,9 +102,17 @@ func LintSkills(rootPath string, quiet bool, verbose bool) (*LintSummary, error)
 		if fmData == nil {
 			fmData = make(map[string]interface{})
 		}
-		suggestions := validateSkillBestPractices(file.RelPath, file.Contents, fmData)
-		result.Suggestions = append(result.Suggestions, suggestions...)
-		summary.TotalSuggestions += len(suggestions)
+		allResults := validateSkillBestPractices(file.RelPath, file.Contents, fmData)
+		// Separate errors from suggestions based on severity
+		for _, r := range allResults {
+			if r.Severity == "error" {
+				result.Errors = append(result.Errors, r)
+				summary.TotalErrors++
+			} else {
+				result.Suggestions = append(result.Suggestions, r)
+				summary.TotalSuggestions++
+			}
+		}
 
 		// Cross-file validation (missing agents)
 		crossErrors := ctx.CrossValidator.ValidateSkill(file.RelPath, file.Contents)
@@ -284,6 +292,9 @@ func validateSkillBestPractices(filePath string, contents string, fmData map[str
 		})
 	}
 
+	// Validate tool field naming (skills use 'allowed-tools:', not 'tools:')
+	suggestions = append(suggestions, ValidateToolFieldName(fmData, filePath, contents, "skill")...)
+
 	// Merge warnings into suggestions for return
 	suggestions = append(suggestions, warnings...)