Merge pull request #154 from avarga1/fix/bugs-135-136-137-138

fix: resolve four bugs in execution, module, context, and workflow

Author: FernandoCelmer

dotflow/core/context.py

@@ -77,6 +77,13 @@ def workflow_id(self):
 
     @workflow_id.setter
     def workflow_id(self, value: UUID):
+        if isinstance(value, str):
+            try:
+                value = UUID(value)
+            except ValueError as err:
+                raise ValueError(
+                    f"Invalid workflow_id: '{value}' is not a valid UUID format."
+                ) from err
         if isinstance(value, UUID):
             self._workflow_id = value
 

dotflow/core/execution.py

@@ -59,7 +59,7 @@ def _is_action(self, class_instance: Callable, func: Callable):
             return (
                 callable(getattr(class_instance, func))
                 and getattr(class_instance, func).__module__
-                is Action.__module__
+                == Action.__module__
                 and not func.startswith("__")
             )
         except AttributeError:

dotflow/core/module.py

@@ -19,7 +19,7 @@ def import_module(cls, value: str):
         spec = file_location(value, cls._get_path(value))
         module = module_from_spec(spec)
 
-        sys.modules[module] = module
+        sys.modules[module.__name__] = module
         spec.loader.exec_module(module)
 
         if hasattr(module, cls._get_name(value)):

dotflow/core/workflow.py

@@ -107,10 +107,16 @@ def __init__(
         execution = None
         groups = grouper(tasks=tasks)
 
-        try:
-            execution = getattr(self, mode)
-        except AttributeError as err:
-            raise ExecutionModeNotExist() from err
+        VALID_MODES = {
+            "sequential",
+            "sequential_group",
+            "background",
+            "parallel",
+        }
+        if mode not in VALID_MODES:
+            raise ExecutionModeNotExist()
+
+        execution = getattr(self, mode)
 
         self.tasks = execution(
             tasks=tasks,