Fix benchmarks with same class but different namespace having same ID (#2522)

caaavik-msft · web-flow · commit 109528020e57 · 2024-02-12T21:38:48.000-05:00
diff --git a/src/BenchmarkDotNet.TestAdapter/BenchmarkCaseExtensions.cs b/src/BenchmarkDotNet.TestAdapter/BenchmarkCaseExtensions.cs
@@ -86,6 +86,7 @@ internal static Guid GetTestCaseId(this BenchmarkCase benchmarkCase)
         {
             var testIdProvider = new TestIdProvider();
             testIdProvider.AppendString(VsTestAdapter.ExecutorUriString);
+            testIdProvider.AppendString(benchmarkCase.Descriptor.Type.Namespace ?? string.Empty);
             testIdProvider.AppendString(benchmarkCase.Descriptor.DisplayInfo);
             testIdProvider.AppendString(benchmarkCase.GetUnrandomizedJobDisplayInfo());
             testIdProvider.AppendString(benchmarkCase.Parameters.DisplayInfo);

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ internal static Guid GetTestCaseId(this BenchmarkCase benchmarkCase)`
`86`	`86`	`{`
`87`	`87`	`var testIdProvider = new TestIdProvider();`
`88`	`88`	`testIdProvider.AppendString(VsTestAdapter.ExecutorUriString);`
	`89`	`+ testIdProvider.AppendString(benchmarkCase.Descriptor.Type.Namespace ?? string.Empty);`
`89`	`90`	`testIdProvider.AppendString(benchmarkCase.Descriptor.DisplayInfo);`
`90`	`91`	`testIdProvider.AppendString(benchmarkCase.GetUnrandomizedJobDisplayInfo());`
`91`	`92`	`testIdProvider.AppendString(benchmarkCase.Parameters.DisplayInfo);`