Skip to content

Commit 3e88680

Browse files
committed
Added Core check with InProcess.
1 parent c918e15 commit 3e88680

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs

+3-1
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,9 @@ private void AssertSurvived(IToolchain toolchain, Type benchmarkType, Dictionary
400400
{
401401
// Core has survived memory measurement problems.
402402
// See https://github.com/dotnet/runtime/issues/45446
403-
if (toolchain is CsProjCoreToolchain || toolchain is CoreRtToolchain) // CoreRt actually does measure accurately in a normal benchmark run, but doesn't with the specific version used in these tests.
403+
if (toolchain is CsProjCoreToolchain
404+
|| (toolchain.IsInProcess && RuntimeInformation.IsNetCore)
405+
|| toolchain is CoreRtToolchain) // CoreRt actually does measure accurately in a normal benchmark run, but doesn't with the specific version used in these tests.
404406
return;
405407

406408
var config = CreateConfig(toolchain, MemoryDiagnoser.WithSurvived);

0 commit comments

Comments
 (0)