Compare types directly.

timcassell · timcassell · commit 584fe39511b2 · 2024-03-10T00:43:30.000-05:00
diff --git a/src/BenchmarkDotNet/Helpers/AwaitHelper.cs b/src/BenchmarkDotNet/Helpers/AwaitHelper.cs
@@ -100,8 +100,7 @@ internal static MethodInfo GetGetResultMethod(Type taskType)
                 {
                     if (m.Name != nameof(AwaitHelper.GetResult)) return false;
                     Type paramType = m.GetParameters().First().ParameterType;
-                    // We have to compare the types indirectly, == check doesn't work.
-                    return paramType.Assembly == compareType.Assembly && paramType.Namespace == compareType.Namespace && paramType.Name == compareType.Name;
+                    return paramType.IsGenericType && paramType.GetGenericTypeDefinition() == compareType;
                 })
                 .MakeGenericMethod(new[] { resultType });
         }

Original file line number	Diff line number	Diff line change
`@@ -100,8 +100,7 @@ internal static MethodInfo GetGetResultMethod(Type taskType)`
`100`	`100`	`{`
`101`	`101`	`if (m.Name != nameof(AwaitHelper.GetResult)) return false;`
`102`	`102`	`Type paramType = m.GetParameters().First().ParameterType;`
`103`		`- // We have to compare the types indirectly, == check doesn't work.`
`104`		`- return paramType.Assembly == compareType.Assembly && paramType.Namespace == compareType.Namespace && paramType.Name == compareType.Name;`
	`103`	`+ return paramType.IsGenericType && paramType.GetGenericTypeDefinition() == compareType;`
`105`	`104`	`})`
`106`	`105`	`.MakeGenericMethod(new[] { resultType });`
`107`	`106`	`}`