Force older DotNetCli partitions to build sequentially.

Revert sdk validator.

Author: timcassell

src/BenchmarkDotNet/Running/BenchmarkRunnerClean.cs

@@ -21,6 +21,7 @@
 using BenchmarkDotNet.Mathematics;
 using BenchmarkDotNet.Reports;
 using BenchmarkDotNet.Toolchains;
+using BenchmarkDotNet.Toolchains.DotNetCli;
 using BenchmarkDotNet.Toolchains.Parameters;
 using BenchmarkDotNet.Toolchains.Results;
 using BenchmarkDotNet.Validators;
@@ -81,17 +82,21 @@ internal static Summary[] Run(BenchmarkRunInfo[] benchmarkRunInfos)
                 compositeLogger.WriteLineHeader($"// ***** Found {totalBenchmarkCount} benchmark(s) in total *****");
                 var globalChronometer = Chronometer.Start();
 
+                var buildPartitions = BenchmarkPartitioner.CreateForBuild(supportedBenchmarks, resolver);
 
-                var parallelBuildBenchmarks = supportedBenchmarks.Where(x => !x.Config.Options.IsSet(ConfigOptions.DisableParallelBuild)).ToArray();
-                var parallelBuildPartitions = BenchmarkPartitioner.CreateForBuild(parallelBuildBenchmarks, resolver);
+                static bool ShouldBuildSequential(BuildPartition partition)
+                    => partition.RepresentativeBenchmarkCase.Config.Options.IsSet(ConfigOptions.DisableParallelBuild)
+                    // .Net SDK 8+ supports ArtifactsPath for proper parallel builds.
+                    // Older SDKs may produce builds with incorrect bindings if more than 1 partition is built in parallel.
+                    || (partition.RepresentativeBenchmarkCase.GetToolchain().Generator is DotNetCliGenerator && partition.RepresentativeBenchmarkCase.GetRuntime().RuntimeMoniker < RuntimeMoniker.Net80);
 
-                var sequentialBuildBenchmarks = supportedBenchmarks.Where(x => x.Config.Options.IsSet(ConfigOptions.DisableParallelBuild)).ToArray();
-                var sequentialBuildPartitions = BenchmarkPartitioner.CreateForBuild(sequentialBuildBenchmarks, resolver);
+                var parallelBuildPartitions = buildPartitions.Where(x => !ShouldBuildSequential(x)).ToArray();
+                var sequentialBuildPartitions = buildPartitions.Where(ShouldBuildSequential).ToArray();
 
                 eventProcessor.OnStartBuildStage([.. parallelBuildPartitions, .. sequentialBuildPartitions]);
 
                 var buildResults = new Dictionary<BuildPartition, BuildResult>();
-                if (parallelBuildBenchmarks.Length > 0)
+                if (parallelBuildPartitions.Length > 0)
                 {
                     var results = BuildInParallel(compositeLogger, rootArtifactsFolderPath, parallelBuildPartitions, in globalChronometer, eventProcessor);
                     foreach (var kvp in results)
@@ -100,7 +105,7 @@ internal static Summary[] Run(BenchmarkRunInfo[] benchmarkRunInfos)
                     }
                 }
 
-                if (sequentialBuildBenchmarks.Length > 0)
+                if (sequentialBuildPartitions.Length > 0)
                 {
                     var results = BuildSequential(compositeLogger, rootArtifactsFolderPath, sequentialBuildPartitions, in globalChronometer, eventProcessor);
                     foreach (var kvp in results)

src/BenchmarkDotNet/Toolchains/CsProj/CsProjClassicNetToolchain.cs

@@ -52,8 +52,12 @@ public override IEnumerable<ValidationError> Validate(BenchmarkCase benchmarkCas
                     benchmarkCase);
                 yield break;
             }
+            else if (DotNetSdkValidator.IsCliPathInvalid(CustomDotNetCliPath, benchmarkCase, out var invalidCliError))
+            {
+                yield return invalidCliError;
+            }
 
-            foreach (var validationError in DotNetSdkValidator.ValidateFrameworkSdks(CustomDotNetCliPath, benchmarkCase))
+            foreach (var validationError in DotNetSdkValidator.ValidateFrameworkSdks(benchmarkCase))
             {
                 yield return validationError;
             }

src/BenchmarkDotNet/Validators/DotNetSdkValidator.cs renamed to src/BenchmarkDotNet/Validators/DotNetSdkVersionValidator.cs

@@ -20,45 +20,30 @@ public static IEnumerable<ValidationError> ValidateCoreSdks(string? customDotNet
             if (IsCliPathInvalid(customDotNetCliPath, benchmark, out ValidationError? cliPathError))
             {
                 yield return cliPathError;
-                yield break;
             }
-            if (!TryGetSdkVersion(benchmark, out Version requiredSdkVersion))
+            else if (TryGetSdkVersion(benchmark, out Version requiredSdkVersion))
             {
-                yield break;
-            }
-
-            var installedSdks = GetInstalledDotNetSdks(customDotNetCliPath);
-            if (!installedSdks.Any(sdk => sdk >= requiredSdkVersion))
-            {
-                yield return new ValidationError(true, $"The required .NET Core SDK version {requiredSdkVersion} or higher for runtime moniker {benchmark.Job.Environment.Runtime.RuntimeMoniker} is not installed.", benchmark);
-            }
-            else if (requiredSdkVersion.Major < 8)
-            {
-                yield return new ValidationError(false, ".Net SDK versions older than 8.0 may produce builds with incorrect bindings.", benchmark);
+                var installedSdks = GetInstalledDotNetSdks(customDotNetCliPath);
+                if (!installedSdks.Any(sdk => sdk >= requiredSdkVersion))
+                {
+                    yield return new ValidationError(true, $"The required .NET Core SDK version {requiredSdkVersion} or higher for runtime moniker {benchmark.Job.Environment.Runtime.RuntimeMoniker} is not installed.", benchmark);
+                }
             }
         }
 
-        public static IEnumerable<ValidationError> ValidateFrameworkSdks(string? customDotNetCliPath, BenchmarkCase benchmark)
+        public static IEnumerable<ValidationError> ValidateFrameworkSdks(BenchmarkCase benchmark)
         {
-            if (IsCliPathInvalid(customDotNetCliPath, benchmark, out ValidationError? cliPathError))
-            {
-                yield return cliPathError;
-                yield break;
-            }
             if (!TryGetSdkVersion(benchmark, out Version requiredSdkVersion))
             {
                 yield break;
             }
 
             var installedVersionString = cachedFrameworkSdks.Value.FirstOrDefault();
+
             if (installedVersionString == null || Version.TryParse(installedVersionString, out var installedVersion) && installedVersion < requiredSdkVersion)
             {
                 yield return new ValidationError(true, $"The required .NET Framework SDK version {requiredSdkVersion} or higher is not installed.", benchmark);
             }
-            else if (requiredSdkVersion.Major < 8)
-            {
-                yield return new ValidationError(false, ".Net SDK versions older than 8.0 may produce builds with incorrect bindings.", benchmark);
-            }
         }
 
         public static bool IsCliPathInvalid(string customDotNetCliPath, BenchmarkCase benchmarkCase, out ValidationError? validationError)