Skip to content

Commit 8c963ba

Browse files
mawosoftAndreyAkinshin
authored andcommitted
Reverting DocFX_Build dependency on Build
In order to work around xref issues in DocFx, BenchmarkDotNet and BenchmarkDotNet.Annotations must be build before running the DocFX_Build target. However, including a dependency on BuildTask here may have unwanted side effects (CleanTask). TODO: Define dependencies when a CI workflow scenario for using the "DocFX_Build" target exists.
1 parent 2e943e3 commit 8c963ba

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

build/Program.cs

+5-2
Original file line numberDiff line numberDiff line change
@@ -453,8 +453,11 @@ public override void Run(BuildContext context)
453453
}
454454
}
455455

456+
// In order to work around xref issues in DocFx, BenchmarkDotNet and BenchmarkDotNet.Annotations must be build
457+
// before running the DocFX_Build target. However, including a dependency on BuildTask here may have unwanted
458+
// side effects (CleanTask).
459+
// TODO: Define dependencies when a CI workflow scenario for using the "DocFX_Build" target exists.
456460
[TaskName("DocFX_Build")]
457-
[IsDependentOn(typeof(BuildTask))] // Required to fix dofx xref issues
458461
[IsDependentOn(typeof(DocfxInstallTask))]
459462
[IsDependentOn(typeof(DocfxChangelogGenerateTask))]
460463
public class DocfxChangelogBuildTask : FrostingTask<BuildContext>
@@ -474,4 +477,4 @@ public override void Run(BuildContext context)
474477
{
475478
context.RunDocfx(context.DocfxJsonFile, "--serve");
476479
}
477-
}
480+
}

0 commit comments

Comments
 (0)