Fix bugs and typos (#2168)

* Fix bugs

* Fix typos in comments

Author: YegorStepanov

src/BenchmarkDotNet.Diagnostics.Windows/Tracing/NativeMemoryLogParser.cs

@@ -217,7 +217,7 @@ bool IsCallStackIn(StackSourceCallStackIndex index)
                     return;
                 }
 
-                // Heap is dieing, kill all objects in it.
+                // Heap is dying, kill all objects in it.
                 var allocs = lastHeapAllocs;
                 if (data.HeapHandle != lastHeapHandle)
                 {

src/BenchmarkDotNet.Diagnostics.Windows/Tracing/TraceLogParser.cs

@@ -160,7 +160,7 @@ public IEnumerable<Metric> CalculateMetrics(Dictionary<int, int> profileSourceId
 
         private IterationData[] CreateIterationData(List<double> startStopTimeStamps)
         {
-            // collection contains mixted .Start and .Stop intervals, if we sort it we know that n is Start and n + 1 is Stop
+            // collection contains mixed .Start and .Stop intervals, if we sort it we know that n is Start and n + 1 is Stop
             startStopTimeStamps.Sort();
 
             var iterations = new IterationData[startStopTimeStamps.Count / 2];

src/BenchmarkDotNet/Attributes/Filters/OperatingSystemsFilterAttribute.cs

@@ -25,7 +25,7 @@ public class OperatingSystemsFilterAttribute : FilterConfigBaseAttribute
         // CLS-Compliant Code requires a constructor without an array in the argument list
         public OperatingSystemsFilterAttribute() { }
 
-        /// <param name="allowed">if set to true, the OSes beloning to platforms are enabled, if set to false, disabled</param>
+        /// <param name="allowed">if set to true, the OSes belonging to platforms are enabled, if set to false, disabled</param>
         /// <param name="platforms">the platform(s) for which the filter should be applied</param>
         public OperatingSystemsFilterAttribute(bool allowed, params OS[] platforms)
             : base(new SimpleFilter(_ =>

src/BenchmarkDotNet/Disassemblers/Exporters/DisassemblyPrettifier.cs

@@ -44,7 +44,7 @@ internal static IReadOnlyList<Element> Prettify(DisassembledMethod method, Disas
                     referencedAddresses.Add(asm.ReferencedAddress.Value);
                 }
 
-            // for every IP that is referenced, we emit a uinque label
+            // for every IP that is referenced, we emit a unique label
             var addressesToLabels = new Dictionary<ulong, string>();
             int currentLabelIndex = 0;
             foreach (var instruction in asmInstructions)

src/BenchmarkDotNet/Environments/HostEnvironmentInfo.cs

@@ -98,7 +98,7 @@ public override IEnumerable<string> ToFormattedString()
 
             if (RuntimeInformation.IsNetCore && IsDotNetCliInstalled())
             {
-                // this wonderfull version number contains words like "preview" and ... 5 segments so it can not be parsed by Version.Parse. Example: "5.0.100-preview.8.20362.3"
+                // this wonderful version number contains words like "preview" and ... 5 segments so it can not be parsed by Version.Parse. Example: "5.0.100-preview.8.20362.3"
                 if (int.TryParse(new string(DotNetSdkVersion.Value.TrimStart().TakeWhile(char.IsDigit).ToArray()), out int major) && major >= 5)
                     yield return $".NET SDK={DotNetSdkVersion.Value}";
                 else

src/BenchmarkDotNet/Jobs/EnvironmentVariable.cs

@@ -8,7 +8,7 @@ public class EnvironmentVariable : IEquatable<EnvironmentVariable>
         public EnvironmentVariable([NotNull] string key, [NotNull] string value)
         {
             Key = key ?? throw new ArgumentNullException(nameof(key));
-            Value = value ?? throw new ArgumentNullException(nameof(Value));
+            Value = value ?? throw new ArgumentNullException(nameof(value));
         }
 
         [NotNull]

src/BenchmarkDotNet/Jobs/NugetReference.cs

@@ -13,7 +13,7 @@ public NuGetReference(string packageName, string packageVersion, Uri source = nu
 
             PackageName = packageName;
 
-            if (!string.IsNullOrWhiteSpace(PackageVersion) && !IsValidVersion(packageVersion))
+            if (!string.IsNullOrWhiteSpace(packageVersion) && !IsValidVersion(packageVersion))
                 throw new InvalidOperationException($"Invalid version specified: {packageVersion}");
 
             PackageVersion = packageVersion ?? string.Empty;

src/BenchmarkDotNet/Reports/BenchmarkReport.cs

@@ -44,7 +44,7 @@ public BenchmarkReport(
             BuildResult = buildResult;
             ExecuteResults = executeResults ?? Array.Empty<ExecuteResult>();
             AllMeasurements = ExecuteResults.SelectMany((results, index) => results.Measurements).ToArray();
-            GcStats = ExecuteResults.Count > 0 ? executeResults[executeResults.Count -1].GcStats : default;
+            GcStats = ExecuteResults.Count > 0 ? ExecuteResults[ExecuteResults.Count - 1].GcStats : default;
             Metrics = metrics?.ToDictionary(metric => metric.Descriptor.Id)
                 ?? (IReadOnlyDictionary<string, Metric>)ImmutableDictionary<string, Metric>.Empty;
         }

src/BenchmarkDotNet/Running/BenchmarkRunnerClean.cs

@@ -49,7 +49,7 @@ internal static Summary[] Run(BenchmarkRunInfo[] benchmarkRunInfos)
 
                 compositeLogger.WriteLineInfo("// Validating benchmarks:");
 
-                var (supportedBenchmarks, validationErrors) = GetSupportedBenchmarks(benchmarkRunInfos, compositeLogger, resolver);
+                var (supportedBenchmarks, validationErrors) = GetSupportedBenchmarks(benchmarkRunInfos, resolver);
 
                 validationErrors.AddRange(Validate(supportedBenchmarks));
 
@@ -532,11 +532,11 @@ private static ExecuteResult RunExecute(ILogger logger, BenchmarkCase benchmarkC
         private static void LogTotalTime(ILogger logger, TimeSpan time, int executedBenchmarksCount, string message = "Total time")
             => logger.WriteLineStatistic($"{message}: {time.ToFormattedTotalTime(DefaultCultureInfo.Instance)}, executed benchmarks: {executedBenchmarksCount}");
 
-        private static (BenchmarkRunInfo[], List<ValidationError>) GetSupportedBenchmarks(BenchmarkRunInfo[] benchmarkRunInfos, ILogger logger, IResolver resolver)
+        private static (BenchmarkRunInfo[], List<ValidationError>) GetSupportedBenchmarks(BenchmarkRunInfo[] benchmarkRunInfos, IResolver resolver)
         {
             List<ValidationError> validationErrors = new ();
 
-            var benchmarksRunInfo = benchmarkRunInfos.Select(info => new BenchmarkRunInfo(
+            var runInfos = benchmarkRunInfos.Select(info => new BenchmarkRunInfo(
                     info.BenchmarksCases.Where(benchmark =>
                     {
                         var errors = benchmark.GetToolchain().Validate(benchmark, resolver).ToArray();
@@ -548,7 +548,7 @@ private static (BenchmarkRunInfo[], List<ValidationError>) GetSupportedBenchmark
                 .Where(infos => infos.BenchmarksCases.Any())
                 .ToArray();
 
-            return (benchmarkRunInfos, validationErrors);
+            return (runInfos, validationErrors);
         }
 
         private static string GetRootArtifactsFolderPath(BenchmarkRunInfo[] benchmarkRunInfos)

tests/BenchmarkDotNet.Tests/Running/BenchmarkConverterTests.cs

@@ -215,7 +215,7 @@ public void MethodDeclarationOrderIsPreserved()
 
         public class BAC
         {
-            // BAC is not sorted in either desceding or ascending way
+            // BAC is not sorted in either descending or ascending way
             [Benchmark] public void B() { }
             [Benchmark] public void A() { }
             [Benchmark] public void C() { }

tests/BenchmarkDotNet.Tests/Running/JobRuntimePropertiesComparerTests.cs

@@ -166,8 +166,8 @@ public void CustomTargetPlatformJobsAreGroupedByTargetFrameworkMoniker()
 
             Assert.Equal(2, grouped.Length);
 
-            Assert.Single(grouped, group => group.Count() == 3); // Plain1 (3 methods) runing against "net5.0"
-            Assert.Single(grouped, group => group.Count() == 6); // Plain2 (3 methods) and Plain3 (3 methods) runing against "net5.0-windows"
+            Assert.Single(grouped, group => group.Count() == 3); // Plain1 (3 methods) running against "net5.0"
+            Assert.Single(grouped, group => group.Count() == 6); // Plain2 (3 methods) and Plain3 (3 methods) running against "net5.0-windows"
         }
     }
 }