Skip to content

Commit d076048

Browse files
authored
Fix wrongly reported os brand string for Windows 10 1909 (#1437)
Fixes #1436
1 parent d95493b commit d076048

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/BenchmarkDotNet/Environments/OsBrandStringHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ public string ToPrettifiedString([CanBeNull] int? ubr)
136136
new Windows10Version(1803, "Redstone 4", "April 2018 Update", 17134),
137137
new Windows10Version(1809, "Redstone 5", "October 2018 Update", 17763),
138138
new Windows10Version(1903, "19H1", "May 2019 Update", 18362),
139-
new Windows10Version(1909, "19H2", "November 2018 Update", 18363),
139+
new Windows10Version(1909, "19H2", "November 2019 Update", 18363),
140140
new Windows10Version(2004, "20H1", "?", 19041)
141141
};
142142

tests/BenchmarkDotNet.Tests/Environments/OsBrandStringTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public void WindowsIsPrettified(string originalVersion, string prettifiedName)
4040
[InlineData("10.0.17134", 48, "Windows 10.0.17134.48 (1803/April2018Update/Redstone4)")]
4141
[InlineData("10.0.17763", 1, "Windows 10.0.17763.1 (1809/October2018Update/Redstone5)")]
4242
[InlineData("10.0.18362", 693, "Windows 10.0.18362.693 (1903/May2019Update/19H1)")]
43-
[InlineData("10.0.18363", 657, "Windows 10.0.18363.657 (1909/November2018Update/19H2)")]
43+
[InlineData("10.0.18363", 657, "Windows 10.0.18363.657 (1909/November2019Update/19H2)")]
4444
[InlineData("10.0.19041", 1, "Windows 10.0.19041.1 (2004/?/20H1)")]
4545
public void WindowsWithUbrIsPrettified(string originalVersion, int ubr, string prettifiedName)
4646
=> Check(OsBrandStringHelper.Prettify("Windows", originalVersion, ubr), prettifiedName);

0 commit comments

Comments
 (0)