Fix output-path regressions in the csproj build plumbing

Three defects found reviewing #3235, originally verified against a
console (exe) benchmark project on NativeAotToolchain -- the shape CI
cannot reach, since BenchmarkDotNet.IntegrationTests is a library.

1. DotNetCliCommand: --no-dependencies was widened to every autogenerated
   build via a filename check. The generated project keeps its
   ProjectReference, and RIDs propagate to exe references but not library
   ones, so the reference resolved to a RID-specific ref assembly that
   nothing produced (CS0006, plus MSB3243 against the gathered Reference).
   Reverted to the previous ForcedNoDependenciesForIntegrationTests gate.

2. GeneratorBase: GetPublishDirectoryPath defaulted to <artifacts>/publish
   while the generators expect the executable in their binaries directory.
   That was masked while --output overrode PublishDir on the command line;
   once PublishDir became authoritative, publish wrote somewhere
   BenchmarkDotNet never looks. Default it to the binaries directory.

3. CsProjGenerator: OutputPath was derived by chopping TFM.Length + 1
   characters off the binaries path, which is wrong for generators whose
   path ends in the RID. Set AppendTargetFrameworkToOutputPath=false in
   the generated props instead.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: timcassell

src/BenchmarkDotNet/Templates/BenchmarkDotNet.Build.props.txt

@@ -7,5 +7,7 @@
   <PropertyGroup Condition="'$(MSBuildProjectFile)' == '$AUTOGENERATED_PROJ$'">
     <OutputPath>$OUTPUT_PATH$</OutputPath>
     <PublishDir>$PUBLISH_DIR$</PublishDir>
+    <!-- OutputPath already ends with the moniker, so MSBuild must not append it again. -->
+    <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
   </PropertyGroup>
 </Project>

src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs

@@ -69,15 +69,12 @@ protected override string GetBinariesDirectoryPath(string buildArtifactsDirector
 
         protected override async ValueTask GenerateCustomBuildHooksAsync(BuildPartition buildPartition, ArtifactsPaths artifactsPaths, ILogger logger, CancellationToken cancellationToken)
         {
-            var benchmark = buildPartition.RepresentativeBenchmarkCase;
-            var benchmarkProjectFile = GetProjectFilePath(benchmark.Descriptor.Type, logger);
-
             var buildArtifactsDirectoryPath = artifactsPaths.BuildArtifactsDirectoryPath;
 
-            // Trim tfm part from binariesDirectoryPath on IntegrationTests. (When ArtifactsPath is not used, it's appended automatically)
-            var binariesDirectoryPath = buildPartition.ForcedNoDependenciesForIntegrationTests
-                ? artifactsPaths.BinariesDirectoryPath.Substring(0, artifactsPaths.BinariesDirectoryPath.Length - Settings.TargetFrameworkMoniker.Length - 1)
-                : artifactsPaths.BinariesDirectoryPath;
+            // The generator already puts the moniker (and for some toolchains the RID) into these
+            // paths, so MSBuild must not append it a second time. It does that whenever the
+            // artifacts layout is not in use, which is the case for our own integration tests.
+            var binariesDirectoryPath = artifactsPaths.BinariesDirectoryPath;
 
             var propsPath = Path.Combine(buildArtifactsDirectoryPath, "BenchmarkDotNet.Build.props");
             var props = GetTemplateContent("BenchmarkDotNet.Build.props.txt");

src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommand.cs

@@ -4,7 +4,6 @@
 using BenchmarkDotNet.Loggers;
 using BenchmarkDotNet.Portability;
 using BenchmarkDotNet.Running;
-using BenchmarkDotNet.Toolchains.CsProj;
 using BenchmarkDotNet.Toolchains.Results;
 using JetBrains.Annotations;
 using System.Text;
@@ -54,8 +53,12 @@ public DotNetCliCommand WithArguments(string arguments)
         public DotNetCliCommand WithCliPath(FileInfo? cliPath)
             => new(cliPath, FilePath, TargetFrameworkMoniker, Arguments, GenerateResult, Logger, BuildPartition, EnvironmentVariables, Timeout, LogOutput);
 
+        // Building without dependencies skips building the referenced benchmark project, so the
+        // generated project's ProjectReference resolves to output that was never produced. That is
+        // only safe for our own integration tests, where the gatherer is skipped and the referenced
+        // project is a library built by the test run itself.
         private bool UseNoDependencies
-            => BuildPartition.IsCustomBuildConfiguration || Path.GetFileName(FilePath) == CsProjGenerator.AutogeneratedProjectName;
+            => BuildPartition.ForcedNoDependenciesForIntegrationTests;
 
         [PublicAPI]
         public async Task<BuildResult> RestoreThenBuildAsync(CancellationToken cancellationToken = default)

src/BenchmarkDotNet/Toolchains/GeneratorBase.cs

@@ -62,11 +62,13 @@ protected virtual string GetBinariesDirectoryPath(string buildArtifactsDirectory
             => buildArtifactsDirectoryPath;
 
         /// <summary>
-        /// returns a path where the publish directory should be found after the build (usually \publish)
+        /// returns a path where `dotnet publish` should write its output. It has to contain the
+        /// executable that <see cref="GetExecutablePath"/> points at, so by default it matches the
+        /// binaries directory.
         /// </summary>
         [PublicAPI]
         protected virtual string GetPublishDirectoryPath(string buildArtifactsDirectoryPath, string configuration)
-            => Path.Combine(buildArtifactsDirectoryPath, "publish");
+            => GetBinariesDirectoryPath(buildArtifactsDirectoryPath, configuration);
 
         /// <summary>
         /// returns OS-specific executable extension