Implement [Arguments] support for InProcessToolchain

[adamsitnik]

[adamsitnik]

Fixed in #921

[melanchall]

Hmm, BenchmarkDotNet v0.12.1:

// Benchmark Benchmarks_ReadFile_MultiSequence_Large.Read_UseBuffering: Job-GUUMIZ(Toolchain=InProcessNoEmitToolchain, InvocationCount=5, IterationCount=5, LaunchCount=5, RunStrategy=Monitoring, WarmupCount=5) [bufferingPolicy=BufferAllData]
// cannot be run in-process. Validation errors:
//    * Arguments are not supported by the InProcessToolchain yet, see #687 for more details

Since the issue is in Closed state, it's pretty strange. Can you please say how to use Arguments with in-process toolchain?

[adamsitnik]

Hi @melanchall

The InProcessToolchain has been obsoleted (you should get a warning about that) in favour of InProcessEmitToolchain:

Please switch to InProcessEmitToolchain and arguments are going to work.

[melanchall]

Hi @adamsitnik,

I use InProcessNoEmitToolchain (Toolchain=InProcessNoEmitToolchain) as you've suggested here. Is InProcessNoEmitToolchain obsolete too?

Also from the message of [Obsolete] attribute I see

[Obsolete("Please use BenchmarkDotNet.Toolchains.InProcess.NoEmit.* classes")]

so it looks like InProcessNoEmitToolchain is the recommended way and should not prevent me of using all the BenchmarkDotNet features.

[adamsitnik]

Hi @melanchall

Please excuse me for the confusion.

The InProcessEmitToolchain is the recommended and best in-process toolchain we have.
If for some reason it does not work on your target .NET Runtime (AOT .NET Runtimes etc) please use InProcessNoEmitToolchain. InProcessToolchain is deprecated, we are going to remove it soon.