[6.1.5 Cherry-pick] Quarantine flaky tests (#4183)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Paul Medynski <31868385+paulmedynski@users.noreply.github.com>

Author: 4 people

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs

@@ -2965,7 +2965,7 @@ internal void ReadSni(TaskCompletionSource<object> completion)
                 // the identity source. The identity value is used to correlate timer callback events to the currently
                 // running timeout and prevents a late timer callback affecting a result it does not relate to
                 int previousTimeoutState = Interlocked.CompareExchange(ref _timeoutState, TimeoutState.Running, TimeoutState.Stopped);
-                Debug.Assert(previousTimeoutState == TimeoutState.Stopped, "previous timeout state was not Stopped");
+
                 if (previousTimeoutState == TimeoutState.Stopped)
                 {
                     Debug.Assert(_timeoutIdentityValue == 0, "timer was previously stopped without resetting the _identityValue");

src/Microsoft.Data.SqlClient/tests/FunctionalTests/LocalizationTest.cs

@@ -40,6 +40,7 @@ public class LocalizationTest
         [InlineData("ru-RU")]
         [InlineData("zh-Hans")]
         [InlineData("zh-Hant")]
+        [Trait("Category", "flaky")]
         public void Localization_Tests(string culture)
         {
             string localized = GetLocalizedErrorMessage(culture);

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

@@ -293,17 +293,17 @@ private static Task<string> AcquireTokenAsync(string authorityURL, string userID
 
         /// <summary>
         /// Returns the current test name as:
-        /// 
+        ///
         ///   ClassName.MethodName
-        /// 
+        ///
         /// xUnit v2 doesn't provide access to a test context, so we use
         /// reflection into the ITestOutputHelper to get the test name.
         /// </summary>
-        /// 
+        ///
         /// <param name="outputHelper">
         ///   The output helper instance for the currently running test.
         /// </param>
-        /// 
+        ///
         /// <returns>The current test name.</returns>
         public static string CurrentTestName(ITestOutputHelper outputHelper)
         {
@@ -316,7 +316,7 @@ public static string CurrentTestName(ITestOutputHelper outputHelper)
             Assert.NotNull(test);
 
             // The DisplayName is in the format:
-            // 
+            //
             //   Namespace.ClassName.MethodName(args)
             //
             // We only want the ClassName.MethodName portion.
@@ -326,7 +326,7 @@ public static string CurrentTestName(ITestOutputHelper outputHelper)
             // There should be 2 groups: the overall match, and the capture
             // group.
             Assert.Equal(2, match.Groups.Count);
-            
+
             // The portion we want is in the capture group.
             return match.Groups[1].Value;
         }
@@ -337,7 +337,7 @@ public static string CurrentTestName(ITestOutputHelper outputHelper)
             // the name, or have (args...) appended.
             @"\.((?:[^.]+)\.(?:[^.\(]+))(?:\(.*\))?$",
             RegexOptions.Compiled);
-        
+
         /// <summary>
         /// SQL Server properties we can query.
         ///
@@ -351,7 +351,7 @@ public enum ServerProperty
             ProductMajorVersion,
             EngineEdition
         }
-        
+
         public static string GetSqlServerProperty(string connectionString, ServerProperty property)
         {
             using SqlConnection conn = new(connectionString);
@@ -474,7 +474,7 @@ public static bool IsEnclaveAzureDatabaseSetup()
         public static bool IsNotAzureSynapse() => !IsAzureSynapse;
 
         public static bool IsNotManagedInstance() => !IsManagedInstance;
-        
+
         // Synapse: UDT Test Database not compatible with Azure Synapse.
         public static bool IsUdtTestDatabasePresent() => IsDatabasePresent(UdtTestDbName) && IsNotAzureSynapse();
 
@@ -585,7 +585,7 @@ public static bool IsSupportingDistributedTransactions()
         public static bool IsUsingNativeSNI() =>
 #if !NETFRAMEWORK
             IsNotUsingManagedSNIOnWindows();
-#else 
+#else
             true;
 #endif
         // Synapse: UTF8 collations are not supported with Azure Synapse.
@@ -671,25 +671,25 @@ private static string GetGuidParts()
         /// succession.  The 12 characters are concatenated together without any
         /// separators.
         /// </summary>
-        /// 
+        ///
         /// <param name="prefix">
         /// The prefix to use when generating the unique name, truncated to at
         /// most 18 characters when withBracket is false, and 16 characters when
         /// withBracket is true.
         ///
         /// This should not contain any characters that cannot be used in
         /// database object names.  See:
-        /// 
+        ///
         /// https://learn.microsoft.com/en-us/sql/relational-databases/databases/database-identifiers?view=sql-server-ver17#rules-for-regular-identifiers
         /// </param>
-        /// 
+        ///
         /// <param name="withBracket">
         /// When true, the entire generated name will be enclosed in square
         /// brackets, for example:
-        /// 
+        ///
         ///   [MyPrefix_7ff01cb811f0]
         /// </param>
-        /// 
+        ///
         /// <returns>
         /// A unique database object name, no more than 30 characters long.
         /// </returns>
@@ -723,7 +723,7 @@ public static string GetShortName(string prefix, bool withBracket = true)
         /// <summary>
         /// Generate a long unique database object name, whose maximum length is
         /// 96 characters, with the format:
-        /// 
+        ///
         ///   <Prefix>_<GuidParts>_<UserName>_<MachineName>
         ///
         /// The Prefix will be truncated to satisfy the overall maximum length.
@@ -742,24 +742,24 @@ public static string GetShortName(string prefix, bool withBracket = true)
         /// The UserName and MachineName are obtained from the Environment,
         /// and will be truncated to satisfy the maximum overall length.
         /// </summary>
-        /// 
+        ///
         /// <param name="prefix">
         /// The prefix to use when generating the unique name, truncated to at
         /// most 32 characters.
         ///
         /// This should not contain any characters that cannot be used in
         /// database object names.  See:
-        /// 
+        ///
         /// https://learn.microsoft.com/en-us/sql/relational-databases/databases/database-identifiers?view=sql-server-ver17#rules-for-regular-identifiers
         /// </param>
-        /// 
+        ///
         /// <param name="withBracket">
         /// When true, the entire generated name will be enclosed in square
         /// brackets, for example:
-        /// 
+        ///
         ///   [MyPrefix_7ff01cb811f0_test_user_ci_agent_machine_name]
         /// </param>
-        /// 
+        ///
         /// <returns>
         /// A unique database object name, no more than 96 characters long.
         /// </returns>
@@ -1332,7 +1332,7 @@ public readonly ref struct XEventScope // IDisposable
 
             /// <summary>
             /// Construct with the specified parameters.
-            /// 
+            ///
             /// This will use the connection to query the server properties and
             /// setup and start the XEvent session.
             /// </summary>
@@ -1350,7 +1350,7 @@ public XEventScope(
                 ushort durationInMinutes = 5)
             {
                 SessionName = GenerateRandomCharacters(sessionName);
-                
+
                 _connection = connection;
                 Assert.Equal(ConnectionState.Open, _connection.State);
 
@@ -1373,7 +1373,7 @@ public XEventScope(
 
                 // Setup and start the XEvent session.
                 string sessionLocation = _isAzureSql ? "DATABASE" : "SERVER";
-                
+
                 // Both Azure SQL and SQL Server 2025+ support setting a maximum
                 // duration for the XEvent session.
                 string duration =
@@ -1394,7 +1394,7 @@ public XEventScope(
                             MEMORY_PARTITION_MODE=NONE,
                             TRACK_CAUSALITY=ON,
                             STARTUP_STATE=OFF)
-                            
+
                         ALTER EVENT SESSION [{SessionName}] ON {sessionLocation} STATE = START ";
 
                 using SqlCommand createXEventSession = new SqlCommand(xEventCreateAndStartCommandText, _connection);

src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj

@@ -79,7 +79,6 @@
     <Compile Include="SQL\AsyncTest\BeginExecAsyncTest.cs" />
     <Compile Include="SQL\AsyncTest\BeginExecReaderAsyncTest.cs" />
     <Compile Include="SQL\AsyncTest\XmlReaderAsyncTest.cs" />
-    <Compile Include="SQL\AsyncTest\AsyncTest.cs" />
     <Compile Include="SQL\AsyncTest\AsyncCancelledConnectionsTest.cs" />
   </ItemGroup>
   <ItemGroup Condition="'$(TestSet)' == '' OR '$(TestSet)' == '2'">

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/AsyncTest/AsyncTest.cs

@@ -28,6 +28,7 @@ public enum AsyncAPI
         // Synapse: WAITFOR DELAY not supported [Parse error at line: 1, column: 1: Incorrect syntax near 'WAITFOR'.]
         [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
         [ClassData(typeof(AsyncTimeoutTestVariations))]
+        [Trait("Category", "flaky")]
         public static void TestDelayedAsyncTimeout(AsyncAPI api, string commonObj, int delayPeriod, bool marsEnabled) =>
             RunTest(api, commonObj, delayPeriod, marsEnabled);
 

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/AsyncTest/AsyncTimeoutTest.cs

@@ -36,6 +36,7 @@ public static class ConnectionPoolTest
         /// </summary>
         [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
         [ClassData(typeof(ConnectionPoolConnectionStringProvider))]
+        [Trait("Category", "flaky")]
         public static void BasicConnectionPoolingTest(string connectionString)
         {
             SqlConnection.ClearAllPools();

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs

@@ -904,6 +904,7 @@ public _Row(int id, Guid documentIdentificationId, string name, string value)
             }
         }
 
+        [Trait("Category", "flaky")]
         [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
         public static async Task CanReadAwkwardDataLengths()
         {