- Added missing isOfficial in the validation stage.

- Addressed Copilot comments.

Author: paulmedynski

eng/pipelines/onebranch/jobs/validate-signed-package-job.yml

@@ -8,15 +8,15 @@ parameters:
   - name: artifactName
     type: string
 
-  # True if this build is a preview.
-  - name: isPreview
-    type: boolean
-
   # True if this build is an official build. This will be used to gate some checks
   # that only apply to official builds, such as signature verification.
   - name: isOfficial
     type: boolean
 
+  # True if this build is a preview.
+  - name: isPreview
+    type: boolean
+
 jobs:
   - job: validate_signed_package
     displayName: Verify SqlClient NuGet Package

eng/pipelines/onebranch/jobs/validate-symbols-job.yml

@@ -11,6 +11,10 @@
 # specified in the 'symbolServers' parameter.
 
 parameters:
+  # True to enable debug information and steps.
+  - name: debug
+    type: boolean
+
   # The list of symbol servers to verify against.  Each entry has a 'name' (friendly display name)
   # and 'url' (the symbol server URL that symchk can query).
   - name: symbolServers
@@ -43,8 +47,9 @@ jobs:
       extractRoot: $(Build.SourcesDirectory)\symchk_packages
 
     steps:
-    - script: SET
-      displayName: Print Environment Variables
+    - ${{ if parameters.debug }}:
+      - script: SET
+        displayName: Print Environment Variables
 
     # ── Download, extract, and verify symbols for each package ──────────────
 
@@ -55,12 +60,14 @@ jobs:
         displayName: Download ${{ pkg.packageName }}
 
       - ${{ each server in parameters.symbolServers }}:
-        - powershell: >
-            $(Build.SourcesDirectory)\eng\pipelines\onebranch\jobs\validate-symbols.ps1
-            -ArtifactPath  "$(Pipeline.Workspace)\${{ pkg.artifactName }}"
-            -ExtractPath   "$(extractRoot)\${{ pkg.packageName }}"
-            -PackageName   "${{ pkg.packageName }}"
-            -DllPath       "${{ pkg.dllPath }}"
-            -SymbolServerUrl  "${{ server.url }}"
-            -SymbolServerName "${{ server.name }}"
+        - task: PowerShell@2
           displayName: Verify ${{ pkg.packageName }} on ${{ server.name }}
+          inputs:
+            filePath: eng/pipelines/onebranch/jobs/validate-symbols.ps1
+            arguments: >
+              -ArtifactPath "$(Pipeline.Workspace)\${{ pkg.artifactName }}"
+              -ExtractPath "$(extractRoot)\${{ pkg.packageName }}"
+              -PackageName "${{ pkg.packageName }}"
+              -DllPath "${{ pkg.dllPath }}"
+              -SymbolServerUrl "${{ server.url }}"
+              -SymbolServerName "${{ server.name }}"

eng/pipelines/onebranch/sqlclient-non-official.yml

@@ -182,15 +182,18 @@ extends:
       - template: /eng/pipelines/onebranch/stages/build-stages.yml@self
         parameters:
           debug: ${{ parameters.debug }}
+          # This is a non-official pipeline.
+          isOfficial: false
           isPreview: ${{ parameters.isPreview }}
-          isOfficial: false # This is a non-official pipeline.
           publishSymbols: ${{ parameters.publishSymbols }}
           buildSqlServerServer: ${{ parameters.buildSqlServerServer }}
           buildSqlClient: ${{ parameters.buildSqlClient }}
           buildAKVProvider: ${{ parameters.buildAKVProvider }}
 
       - template: /eng/pipelines/onebranch/stages/validation-stage.yml@self
         parameters:
+          debug: ${{ parameters.debug }}
+          isOfficial: false
           isPreview: ${{ parameters.isPreview }}
           publishSymbols: ${{ parameters.publishSymbols }}
           buildSqlServerServer: ${{ parameters.buildSqlServerServer }}
@@ -200,10 +203,9 @@ extends:
       - template: /eng/pipelines/onebranch/stages/release-stage.yml@self
         parameters:
           debug: ${{ parameters.debug }}
+          isOfficial: false
           # Non-official pipelines always push to the NuGet Test feed.
           releaseToProduction: false
-          # This is _not_ an official pipeline.
-          isOfficial: false
           stageNameSuffix: test
           releaseSqlServerServer: ${{ parameters.releaseSqlServerServer }}
           releaseLogging: ${{ parameters.releaseLogging }}

eng/pipelines/onebranch/sqlclient-official.yml

@@ -207,15 +207,18 @@ extends:
       - template: /eng/pipelines/onebranch/stages/build-stages.yml@self
         parameters:
           debug: ${{ parameters.debug }}
+          # This is an official pipeline.
+          isOfficial: true
           isPreview: ${{ parameters.isPreview }}
-          isOfficial: true # This is an official pipeline.
           publishSymbols: ${{ parameters.publishSymbols }}
           buildSqlServerServer: ${{ parameters.buildSqlServerServer }}
           buildSqlClient: ${{ parameters.buildSqlClient }}
           buildAKVProvider: ${{ parameters.buildAKVProvider }}
 
       - template: /eng/pipelines/onebranch/stages/validation-stage.yml@self
         parameters:
+          debug: ${{ parameters.debug }}
+          isOfficial: true
           isPreview: ${{ parameters.isPreview }}
           publishSymbols: ${{ parameters.publishSymbols }}
           buildSqlServerServer: ${{ parameters.buildSqlServerServer }}
@@ -225,9 +228,8 @@ extends:
       - template: /eng/pipelines/onebranch/stages/release-stage.yml@self
         parameters:
           debug: ${{ parameters.debug }}
-          releaseToProduction: ${{ parameters.releaseToProduction }}
-          # This is an official pipeline.
           isOfficial: true
+          releaseToProduction: ${{ parameters.releaseToProduction }}
           stageNameSuffix: production
           releaseSqlServerServer: ${{ parameters.releaseSqlServerServer }}
           releaseLogging: ${{ parameters.releaseLogging }}

eng/pipelines/onebranch/stages/build-stages.yml

@@ -33,16 +33,16 @@ parameters:
   - name: debug
     type: boolean
 
-  # True if this is a preview build, which uses the preview version numbers from
-  # common-variables.yml.
-  - name: isPreview
-    type: boolean
-
   # True if this is an official build, which runs additional ESRP malware scanning
   # and codesigning steps.
   - name: isOfficial
     type: boolean
 
+  # True if this is a preview build, which uses the preview version numbers from
+  # common-variables.yml.
+  - name: isPreview
+    type: boolean
+
   # True to publish symbols to public and private servers.
   - name: publishSymbols
     type: boolean

eng/pipelines/onebranch/stages/release-stage.yml

@@ -42,6 +42,10 @@ parameters:
   - name: debug
     type: boolean
 
+  # True for a OneBranch Official pipeline, false for a Non-Official pipeline.
+  - name: isOfficial
+    type: boolean
+
   # Controls where packages are pushed during the release stage.
   #
   # When true, packages are pushed to the NuGet Production feed.
@@ -51,10 +55,6 @@ parameters:
     type: boolean
     default: false
 
-  # True for a OneBranch Official pipeline, false for a Non-Official pipeline.
-  - name: isOfficial
-    type: boolean
-
   # The stage name suffix, used in the stage ID (e.g. release_production) and display name.
   - name: stageNameSuffix
     type: string
@@ -103,6 +103,11 @@ stages:
       ${{ else }}:
         displayName: Release to NuGet Test
       dependsOn:
+        # We always depend on validation.  That stage has its own checks to gate execution of the
+        # validation jobs, so it's safe to depend on it unconditionally.
+        - validation
+        # Additionally, we depend on the build stages corresponding to any packages we intend to
+        # release.
         - ${{ if or(parameters.releaseSqlServerServer, parameters.releaseLogging) }}:
           - build_independent
         - ${{ if parameters.releaseAbstractions }}:

eng/pipelines/onebranch/stages/validation-stage.yml

@@ -17,6 +17,14 @@
 parameters:
   # ── General parameters ─────────────────────────────────────────────────
 
+  # True to enable debug information and steps.
+  - name: debug
+    type: boolean
+
+  # True for a OneBranch Official pipeline, false for a Non-Official pipeline.
+  - name: isOfficial
+    type: boolean
+
   # True if this is a preview build.
   - name: isPreview
     type: boolean
@@ -55,12 +63,14 @@ stages:
         - template: /eng/pipelines/onebranch/jobs/validate-signed-package-job.yml@self
           parameters:
             artifactName: $(sqlClientArtifactsName)
+            isOfficial: ${{ parameters.isOfficial }}
             isPreview: ${{ parameters.isPreview }}
 
       # ── Symbol-server validation ───────────────────────────────────
       - ${{ if eq(parameters.publishSymbols, true) }}:
         - template: /eng/pipelines/onebranch/jobs/validate-symbols-job.yml@self
           parameters:
+            debug: ${{ parameters.debug }}
             packages:
               # SqlServer — only when buildSqlServerServer is true.
               - ${{ if eq(parameters.buildSqlServerServer, true) }}: