Skip to content

Commit 3afd216

Browse files
committed
Address copilot feedback round 1 of n
1 parent 27912d5 commit 3afd216

5 files changed

Lines changed: 11 additions & 6 deletions

File tree

eng/pipelines/pr/stages/test-stages.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,13 @@ parameters:
7474
type: string
7575

7676
# This is an array of objects with the following fields:
77-
# - displayName - Friendly name to use when displaying the stage name and job names. This must
78-
# only contain alphanumeric characters and '_'. It will be used for both display
79-
# name fields and stage/job names.
80-
# - dotnet - Version of dotnet runtime to use to execute the tests
81-
# - image - Image to use to execute the test jobs in the pipeline
77+
# - displayName - Friendly name to use when displaying the stage name and job names. This
78+
# must only contain alphanumeric characters and '_'. It will be used for both
79+
# display name fields and stage/job names.
80+
# - dotnet - Version of dotnet runtime to use to execute the tests
81+
# - image - Image to use to execute the test jobs in the pipeline
82+
# - operatingSystem - General OS "class" that the image contains. This is used to switch between
83+
# server configuration behaviors.
8284
#
8385
# Each one of the objects in this parameter will become a stage that executes all test projects
8486
# available.

eng/pipelines/pr/steps/build-buildproj-step.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ steps:
3939
projects: build.proj
4040
arguments: >-
4141
-t:Build${{ parameters.packageShortName }}
42+
-p:Configuration=${{ parameters.buildConfiguration }}
4243
-p:BuildNumber='$(Build.BuildNumber)'
4344
-p:BuildSuffix='${{ parameters.buildSuffix }}'
4445

eng/pipelines/pr/steps/pack-buildproj-step.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,6 @@ steps:
5454
verbosity: detailed
5555
arguments: >-
5656
-t:Pack${{ parameters.packageShortName }}
57+
-p:Configuration=${{ parameters.buildConfiguration }}
5758
-p:BuildNumber='$(Build.BuildNumber)'
5859
-p:BuildSuffix='${{ parameters.buildSuffix }}'

eng/pipelines/pr/steps/test-buildproj-step.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ steps:
5353
verbosity: detailed
5454
arguments: >-
5555
-t:Test${{ parameters.packageShortName }}${{ parameters.testProject }}
56+
-p:Configuration=${{ parameters.buildConfiguration }}
5657
-p:BuildNumber='$(Build.BuildNumber)'
5758
-p:BuildSuffix='${{ parameters.buildSuffix }}'
5859
-p:TestFramework=${{ parameters.testFramework }}

src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/config.default.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,6 @@
3636
"AliasName": "",
3737
"WorkloadIdentityFederationServiceConnectionId": "",
3838
"KerberosDomainPassword": "",
39-
"KerberosDomainuser": "",
39+
"KerberosDomainUser": "",
4040
"IsManagedInstance": false
4141
}

0 commit comments

Comments
 (0)