Skip to content

Commit c6bf797

Browse files
committed
Address Copilot review: fix verbosity switch and boolean comparisons
- Change -verbosity: to --verbosity for dotnet CLI consistency - Change isInternalBuild comparisons from string 'True' to boolean true
1 parent 583f875 commit c6bf797

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

eng/pipelines/ci/package/sqlclient-package.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ variables:
9191
# Signing key argument passed to build.proj. On internal builds this references the secure file
9292
# downloaded by DownloadSecureFile@1; on public builds it expands to empty.
9393
- name: signingKeyArg
94-
${{ if eq(variables.isInternalBuild, 'True') }}:
94+
${{ if eq(variables.isInternalBuild, true) }}:
9595
value: '-p:SigningKeyPath="$(keyFile.secureFilePath)"'
9696
${{ else }}:
9797
value: ''
@@ -101,7 +101,7 @@ jobs:
101101
displayName: Pack All Packages
102102

103103
pool:
104-
${{ if eq(variables.isInternalBuild, 'True') }}:
104+
${{ if eq(variables.isInternalBuild, true) }}:
105105
name: ADO-1ES-Pool
106106
${{ else }}:
107107
name: ADO-CI-1ES-Pool
@@ -131,7 +131,7 @@ jobs:
131131
displayName: Clean packages/ directory
132132
133133
# On internal builds, download the strong-name signing key.
134-
- ${{ if eq(variables.isInternalBuild, 'True') }}:
134+
- ${{ if eq(variables.isInternalBuild, true) }}:
135135
- task: DownloadSecureFile@1
136136
displayName: Download Signing Key
137137
inputs:
@@ -151,7 +151,7 @@ jobs:
151151
-p:BuildNumber="$(Build.BuildNumber)"
152152
-p:BuildSuffix=ci
153153
$(signingKeyArg)
154-
-verbosity:${{ parameters.dotnetVerbosity }}
154+
--verbosity ${{ parameters.dotnetVerbosity }}
155155
156156
# List produced packages for diagnostics.
157157
- pwsh: |

0 commit comments

Comments
 (0)