Probably fixing that bug

benrr101 · benrr101 · commit ca5037e47c4c · 2025-10-22T12:26:11.000-05:00
diff --git a/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommand.Encryption.cs b/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommand.Encryption.cs
@@ -140,7 +140,7 @@ private SqlParameter BuildStoredProcedureStatementForColumnEncryption(
             if (returnValueParameter is not null)
             {
                 SqlParameter.AppendPrefixedParameterName(execStatement, returnValueParameter.ParameterName);
-                execStatement.Append("=");
+                execStatement.Append('=');
             }
 
             execStatement.Append(ParseAndQuoteIdentifier(storedProcedureName, isUdtTypeName: false));
@@ -198,7 +198,7 @@ private SqlParameter BuildStoredProcedureStatementForColumnEncryption(
                 // @TODO: Invert
                 if (parameter.Direction is not ParameterDirection.ReturnValue)
                 {
-                    execStatement.Append(' ');
+                    execStatement.Append(", ");
                     SqlParameter.AppendPrefixedParameterName(execStatement, parameter.ParameterName);
                     execStatement.Append('=');
                     SqlParameter.AppendPrefixedParameterName(execStatement, parameter.ParameterName);

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ private SqlParameter BuildStoredProcedureStatementForColumnEncryption(`
`140`	`140`	`if (returnValueParameter is not null)`
`141`	`141`	`{`
`142`	`142`	`SqlParameter.AppendPrefixedParameterName(execStatement, returnValueParameter.ParameterName);`
`143`		`- execStatement.Append("=");`
	`143`	`+ execStatement.Append('=');`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`execStatement.Append(ParseAndQuoteIdentifier(storedProcedureName, isUdtTypeName: false));`
`@@ -198,7 +198,7 @@ private SqlParameter BuildStoredProcedureStatementForColumnEncryption(`
`198`	`198`	`// @TODO: Invert`
`199`	`199`	`if (parameter.Direction is not ParameterDirection.ReturnValue)`
`200`	`200`	`{`
`201`		`- execStatement.Append(' ');`
	`201`	`+ execStatement.Append(", ");`
`202`	`202`	`SqlParameter.AppendPrefixedParameterName(execStatement, parameter.ParameterName);`
`203`	`203`	`execStatement.Append('=');`
`204`	`204`	`SqlParameter.AppendPrefixedParameterName(execStatement, parameter.ParameterName);`