Address feedback

Author: grendello

src/Xamarin.Android.Build.Tasks/Mono.Android/ApplicationAttribute.Partial.cs

@@ -57,12 +57,6 @@ static partial void AddManualMapping ()
 
 		public static ApplicationAttribute FromCustomAttributeProvider (ICustomAttributeProvider provider, TypeDefinitionCache cache)
 		{
-			// `provider` might be null in situations when application configuration is broken, and it surfaces in a number of
-			// tests which check these situations.
-			if (provider == null) {
-				return null;
-			}
-
 			CustomAttribute attr = provider.GetCustomAttributes ("Android.App.ApplicationAttribute")
 				.SingleOrDefault ();
 			if (attr == null)

src/Xamarin.Android.Build.Tasks/Mono.Android/InstrumentationAttribute.Partial.cs

@@ -16,12 +16,6 @@ partial class InstrumentationAttribute {
 
 		public static IEnumerable<InstrumentationAttribute> FromCustomAttributeProvider (ICustomAttributeProvider provider, TypeDefinitionCache cache)
 		{
-			// `provider` might be null in situations when application configuration is broken, and it surfaces in a number of
-			// tests which check these situations.
-			if (provider == null) {
-				yield break;
-			}
-
 			foreach (CustomAttribute attr in provider.GetCustomAttributes ("Android.App.InstrumentationAttribute")) {
 				InstrumentationAttribute self = new InstrumentationAttribute ();
 				self.specified = mapping.Load (self, attr, cache);

src/Xamarin.Android.Build.Tasks/Mono.Android/PermissionAttribute.Partial.cs

@@ -21,12 +21,6 @@ partial class PermissionAttribute {
 
 		public static IEnumerable<PermissionAttribute> FromCustomAttributeProvider (ICustomAttributeProvider provider, TypeDefinitionCache cache)
 		{
-			// `provider` might be null in situations when application configuration is broken, and it surfaces in a number of
-			// tests which check these situations.
-			if (provider == null) {
-				yield break;
-			}
-
 			var attrs = provider.GetCustomAttributes ("Android.App.PermissionAttribute");
 			foreach (var attr in attrs) {
 				PermissionAttribute self = new PermissionAttribute ();

src/Xamarin.Android.Build.Tasks/Mono.Android/PermissionGroupAttribute.Partial.cs

@@ -21,12 +21,6 @@ partial class PermissionGroupAttribute {
 
 		public static IEnumerable<PermissionGroupAttribute> FromCustomAttributeProvider (ICustomAttributeProvider provider, TypeDefinitionCache cache)
 		{
-			// `provider` might be null in situations when application configuration is broken, and it surfaces in a number of
-			// tests which check these situations.
-			if (provider == null) {
-				yield break;
-			}
-
 			var attrs = provider.GetCustomAttributes ("Android.App.PermissionGroupAttribute");
 			foreach (var attr in attrs) {
 				PermissionGroupAttribute self = new PermissionGroupAttribute ();

src/Xamarin.Android.Build.Tasks/Mono.Android/PermissionTreeAttribute.Partial.cs

@@ -21,12 +21,6 @@ partial class PermissionTreeAttribute {
 
 		public static IEnumerable<PermissionTreeAttribute> FromCustomAttributeProvider (ICustomAttributeProvider provider, TypeDefinitionCache cache)
 		{
-			// `provider` might be null in situations when application configuration is broken, and it surfaces in a number of
-			// tests which check these situations.
-			if (provider == null) {
-				yield break;
-			}
-
 			var attrs = provider.GetCustomAttributes ("Android.App.PermissionTreeAttribute");
 			foreach (var attr in attrs) {
 				PermissionTreeAttribute self = new PermissionTreeAttribute ();

src/Xamarin.Android.Build.Tasks/Mono.Android/SupportsGLTextureAttribute.Partial.cs

@@ -29,12 +29,6 @@ internal XElement ToElement (string packageName, TypeDefinitionCache cache)
 
 		public static IEnumerable<SupportsGLTextureAttribute> FromCustomAttributeProvider (ICustomAttributeProvider provider, TypeDefinitionCache cache)
 		{
-			// `provider` might be null in situations when application configuration is broken, and it surfaces in a number of
-			// tests which check these situations.
-			if (provider == null) {
-				yield break;
-			}
-
 			var attrs = provider.GetCustomAttributes ("Android.App.SupportsGLTextureAttribute");
 			foreach (var attr in attrs) {
 				if (attr.HasConstructorArguments && attr.ConstructorArguments.Count == 1) {

src/Xamarin.Android.Build.Tasks/Mono.Android/UsesFeatureAttribute.Partial.cs

@@ -35,12 +35,6 @@ internal XElement ToElement (string packageName, TypeDefinitionCache cache)
 
 		public static IEnumerable<UsesFeatureAttribute> FromCustomAttributeProvider (ICustomAttributeProvider provider, TypeDefinitionCache cache)
 		{
-			// `provider` might be null in situations when application configuration is broken, and it surfaces in a number of
-			// tests which check these situations.
-			if (provider == null) {
-				yield break;
-			}
-
 			var attrs = provider.GetCustomAttributes ("Android.App.UsesFeatureAttribute");
 			foreach (var attr in attrs) {
 

src/Xamarin.Android.Build.Tasks/Mono.Android/UsesPermissionAttribute.Partial.cs

@@ -16,12 +16,6 @@ partial class UsesPermissionAttribute {
 
 		public static IEnumerable<UsesPermissionAttribute> FromCustomAttributeProvider (ICustomAttributeProvider provider, TypeDefinitionCache cache)
 		{
-			// `provider` might be null in situations when application configuration is broken, and it surfaces in a number of
-			// tests which check these situations.
-			if (provider == null) {
-				yield break;
-			}
-
 			var attrs = provider.GetCustomAttributes ("Android.App.UsesPermissionAttribute");
 			foreach (var attr in attrs) {
 				UsesPermissionAttribute self;