Maui Community Toolkit Camera trimming bug

[ne0rrmatrix]

Android framework version

net9.0-android

Affected platform version

VS 2022, Dotnet Maui 9.102, CommunityTookit Camera

Description

I am trying to figure out how to fix the Maui Community toolkit Camera package. When in debug mode everything works as expected. In Release mode the Zoom in and out do not work. I have isolated it to the sample app trimming out Xamarin.AndroidX.Camera.Core. Adding this to sample app project fixes the bug

<ItemGroup Condition="$(TargetFramework.Contains('-android'))">
   <TrimmerRootDescriptor Include="ILLink.Descriptors.xml"/>
 </ItemGroup> 

The ILLink.Descriptors.xml

<?xml version="1.0" encoding="UTF-8" ?>
<linker>
  <assembly fullname="Xamarin.AndroidX.Camera.Core" />
</linker>

I would prefer to fix the trimming issue and not have to rely on having to ask consumers of a nuget package to add a TrimmerRootDescriptor xml file to csproj. I have included the build Android-arm64 linked folder as a zip file.

linked.zip

Steps to Reproduce

1. Run this project. https://github.com/CommunityToolkit/Maui/tree/main/samples
2. Goto Views, open the camera app in Release mode.
3. Set zoom slider or click to zoom in and out.
4. Issue is that zoom in and out does not work. Everything else works fine.
5. Issue does not occur in Debug mode.

Did you find any workaround?

Add a ILLinkDescriptors.xml to sample app and that fixes it. Prevent Xamarin.AndroidX.Camera.Core from being trimmed.

Relevant log output

[jonathanpeppers]

Issue is that zoom in and out does not work. Everything else works fine.

Can you describe more why it doesn't work? Is an exception thrown? Which method doesn't work as expected? Can you share a link to it?

[ne0rrmatrix]

The min and max zoom report static values of 1 in release mode. In debug mode the values are different. I check that value I want to set is above min value and below max. The value reported for camera max and min is same value in release mode. In debug it shows the cameras values. In release mode it shows static default values.

[ne0rrmatrix]

Here is link to function I am calling. https://github.com/CommunityToolkit/Maui/blob/d694f5f11d66c15718886c01d370089347822436/src/CommunityToolkit.Maui.Camera/CameraManager.android.cs on line 64 I call

public partial void UpdateZoom(float zoomLevel)
	{
		cameraControl?.SetZoomRatio(zoomLevel);
	}

Here is relevant bindings file: https://github.com/CommunityToolkit/Maui/blob/main/src/CommunityToolkit.Maui.Camera/Views/CameraView.shared.cs
Line 254 - 274

static object CoerceZoom(BindableObject bindable, object value)
	{
		var cameraView = (CameraView)bindable;
		var input = (float)value;

		if (cameraView.SelectedCamera is null)
		{
			return input;
		}

		if (input < cameraView.SelectedCamera.MinimumZoomFactor)
		{
			input = cameraView.SelectedCamera.MinimumZoomFactor;
		}
		else if (input > cameraView.SelectedCamera.MaximumZoomFactor)
		{
			input = cameraView.SelectedCamera.MaximumZoomFactor;
		}

		return input;
	}

[ne0rrmatrix]

If I remove the check for min and max zoom I can zoom in and out. I have narrowed it down to the min and max zoom are not available. It is simply reporting default values as set by my project for when they are not available. In release mode for what ever reason those values are not available when trimming is on.

[ne0rrmatrix]

Here is a link to a new sample that is just a blank app with camera bug added to it. https://github.com/ne0rrmatrix/CameraTest
Just run in release mode and try and zoom using slider. Does not work. Works as expected in debug mode.

On line 48 of csroj uncomment ItemGroup to see it working with TrimmerRootDescriptor

Direct link to changes for workaround: ne0rrmatrix/CameraTest@5d24af0