Skip to content

Source-flow PRs are removing required darc-* feeds added by dependency flow; automation should recompute feeds from Version.Details.xml #5623

@mmitche

Description

@mmitche

Pull request

https://github.com/dotnet/diagnostics/pull/5645/files

Type of problem

Problem with version files (Versions.Details.xml, Versions.props, global.json, ..)

Description of the issue

Summary
In multiple recent PRs, a dependency-flow update correctly adds the necessary darc-* feed(s) to NuGet.config so the repo can restore serviced assets. A subsequent source-flow PR then removes those feed entries, breaking package restore. This is causing restore failures until the feeds are manually re-added.

“Unable to find a stable package Microsoft.CodeAnalysis.NetAnalyzers with version (>= 10.0.102)”
Analysis in the thread shows the PR removed the darc-pub feed that contained the 10.0.102 assets, leading directly to the restore failure.

Expected behavior (per Matt Mitchell (.NET))
After any dependency update, automation should examine the resulting Version.Details.xml, determine where each dependency is sourced, and compile the minimal set of darc-* feeds required to satisfy those dependencies. Only when assets are promoted (e.g., post-release) and the dependency locations switch to nuget.org should feeds be pruned. Current behavior appears to skip this reconciliation step in source-flow PRs.

Observed behavior

  • Dependency-flow PR adds required darc-* feed(s) to NuGet.config.
  • Source-flow PR later removes those feed entries, even though the dependency graph (per Version.Details.xml) still needs them, causing restore failures.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions