Remove Windows PDB conversion

[ViktorHofer]

arcade/src/Microsoft.DotNet.Arcade.Sdk/tools/ProjectDefaults.props

Lines 32 to 33 in 490307d

	- Convert Portable PDBs to Windows PDBs and publish the converted PDBs to Symbol Store to allow WinDBG,
	Watson and other tools to find symbol format they understand.

Windows PDBs were originally produced to support tools like WinDbg and Watson. From what I see, both of these tools already support portable PDBs. I.e.: https://github.com/MicrosoftDocs/windows-driver-docs/blob/staging/windows-driver-docs-pr/debugger/symbols-portable-pdb.md#portable-pdb-symbols

Roslyn, razor and maybe others also don't produce them anymore: dotnet/roslyn#64581

Unless someone still knows reasons to keep producing Windows PDBs, we should disable the conversion and remove the associated infrastructure. Bonus: This also removes differences in the VMR build which currently disables the windows PDB generation in three repos: https://github.com/search?q=repo%3Adotnet%2Fsdk%20PublishWindowsPdb&type=code

cc @mmitche @akoeplinger @tmat

[rainersigwald]

We should make sure that the VS-insertion symbol check process can handle the portable PDBs too; IIRC that was a sticking point for MSBuild in the past. But hopefully resolved a while ago . . .

[akoeplinger]

@rainersigwald according to the description on dotnet/roslyn#64581 they already validated that a couple years ago :)

[rainersigwald]

Ah indeed!