Address feedback on Azure Container Registry (#9131)

Author: captainsafia

src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppsInfrastructure.cs

@@ -62,13 +62,11 @@ public async Task BeforeStartAsync(DistributedApplicationModel appModel, Cancell
             // Capture information about the container registry used by the
             // container app environment in the deployment target information
             // associated with each compute resource that needs an image
-#pragma warning disable ASPIRECOMPUTE001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
             r.Annotations.Add(new DeploymentTargetAnnotation(containerApp)
             {
                 ContainerRegistry = caes.FirstOrDefault(),
-                ComputeEnvironment = environment as IComputeEnvironmentResource
+                ComputeEnvironment = environment as IComputeEnvironmentResource // will be null if azd
             });
-#pragma warning restore ASPIRECOMPUTE001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
         }
 
         static void SetKnownParameterValue(AzureBicepResource r, string key, Func<AzureBicepResource, object> factory)

src/Aspire.Hosting.Azure.ContainerRegistry/Aspire.Hosting.Azure.ContainerRegistry.csproj

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <TargetFramework>$(DefaultTargetFramework)</TargetFramework>
     <IsPackable>true</IsPackable>
-    <PackageTags>aspire integration hosting azure containerregistry</PackageTags>
+    <PackageTags>aspire integration hosting azure container registry</PackageTags>
     <Description>Azure Container Registry resource types for .NET Aspire.</Description>
     <EnablePackageValidation>false</EnablePackageValidation>
     <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>

src/Aspire.Hosting.Azure.ContainerRegistry/AzureContainerRegistryResource.cs

@@ -18,15 +18,15 @@ public class AzureContainerRegistryResource(string name, Action<AzureResourceInf
     /// <summary>
     /// The name of the Azure Container Registry.
     /// </summary>
-    public BicepOutputReference RegistryName => new("name", this);
+    public BicepOutputReference NameOutputReference => new("name", this);
 
     /// <summary>
     /// The endpoint of the Azure Container Registry.
     /// </summary>
     public BicepOutputReference RegistryEndpoint => new("loginServer", this);
 
     /// <inheritdoc/>
-    ReferenceExpression IContainerRegistry.Name => ReferenceExpression.Create($"{RegistryName}");
+    ReferenceExpression IContainerRegistry.Name => ReferenceExpression.Create($"{NameOutputReference}");
 
     /// <inheritdoc/>
     ReferenceExpression IContainerRegistry.Endpoint => ReferenceExpression.Create($"{RegistryEndpoint}");
@@ -35,7 +35,7 @@ public class AzureContainerRegistryResource(string name, Action<AzureResourceInf
     public override ProvisionableResource AddAsExistingResource(AzureResourceInfrastructure infra)
     {
         var store = ContainerRegistryService.FromExisting(this.GetBicepIdentifier());
-        store.Name = RegistryName.AsProvisioningParameter(infra);
+        store.Name = NameOutputReference.AsProvisioningParameter(infra);
         infra.Add(store);
         return store;
     }

src/Aspire.Hosting.Azure.ContainerRegistry/ContainerRegistryReferenceAnnotation.cs renamed to src/Aspire.Hosting/ApplicationModel/ContainerRegistryReferenceAnnotation.cs

@@ -3,9 +3,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-using Aspire.Hosting.ApplicationModel;
-
-namespace Aspire.Hosting.Azure;
+namespace Aspire.Hosting.ApplicationModel;
 
 /// <summary>
 /// Annotation that indicates a resource is using a specific container registry.