Skip to content

Commit 36edcda

Browse files
committed
Revert AspireBlobStorageBuilder
1 parent 05a0921 commit 36edcda

File tree

3 files changed

+6
-91
lines changed

3 files changed

+6
-91
lines changed

playground/AzureStorageEndToEnd/AzureStorageEndToEnd.ApiService/Program.cs

+2-18
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@
88

99
builder.AddServiceDefaults();
1010

11-
builder.AddAzureBlobClient("blobs")
12-
.AddKeyedAzureBlobContainerClient(blobContainerName: "test-container-1")
13-
.AddKeyedAzureBlobContainerClient(blobContainerName: "test-container-2");
11+
builder.AddAzureBlobClient("blobs");
1412
builder.AddKeyedAzureBlobContainerClient("foocontainer");
1513

1614
builder.AddAzureQueueClient("queues");
@@ -19,21 +17,7 @@
1917

2018
app.MapDefaultEndpoints();
2119

22-
app.MapGet("/", async ([FromKeyedServices("test-container-1")] BlobContainerClient keyedContainerClient1,
23-
[FromKeyedServices("foocontainer")] BlobContainerClient keyedContainerClient2) =>
24-
{
25-
var blobNames = new List<string>();
26-
var blobNameAndContent = Guid.NewGuid().ToString();
27-
28-
await keyedContainerClient1.UploadBlobAsync(blobNameAndContent, new BinaryData(blobNameAndContent));
29-
await keyedContainerClient2.UploadBlobAsync(blobNameAndContent, new BinaryData(blobNameAndContent));
30-
31-
await ReadBlobsAsync(keyedContainerClient1, blobNames);
32-
await ReadBlobsAsync(keyedContainerClient2, blobNames);
33-
34-
return blobNames;
35-
});
36-
app.MapGet("/test", async (BlobServiceClient bsc, QueueServiceClient qsc, [FromKeyedServices("test-container-2")] BlobContainerClient keyedContainerClient1) =>
20+
app.MapGet("/", async (BlobServiceClient bsc, QueueServiceClient qsc, [FromKeyedServices("foocontainer")] BlobContainerClient keyedContainerClient1) =>
3721
{
3822
var blobNames = new List<string>();
3923
var blobNameAndContent = Guid.NewGuid().ToString();

src/Components/Aspire.Azure.Storage.Blobs/AspireBlobStorageBuilder.cs

-65
This file was deleted.

src/Components/Aspire.Azure.Storage.Blobs/AspireBlobStorageExtensions.cs

+4-8
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public static partial class AspireBlobStorageExtensions
3333
/// <exception cref="InvalidOperationException">
3434
/// Neither <see cref="AzureStorageBlobsSettings.ConnectionString"/> nor <see cref="AzureStorageBlobsSettings.ServiceUri"/> is provided.
3535
/// </exception>
36-
public static AspireBlobStorageBuilder AddAzureBlobClient(
36+
public static void AddAzureBlobClient(
3737
this IHostApplicationBuilder builder,
3838
string connectionName,
3939
Action<AzureStorageBlobsSettings>? configureSettings = null,
@@ -42,9 +42,7 @@ public static AspireBlobStorageBuilder AddAzureBlobClient(
4242
ArgumentNullException.ThrowIfNull(builder);
4343
ArgumentException.ThrowIfNullOrEmpty(connectionName);
4444

45-
var settings = new BlobStorageComponent().AddClient(builder, DefaultConfigSectionName, configureSettings, configureClientBuilder, connectionName, serviceKey: null);
46-
47-
return new AspireBlobStorageBuilder(builder, connectionName, serviceKey: null, settings);
45+
new BlobStorageComponent().AddClient(builder, DefaultConfigSectionName, configureSettings, configureClientBuilder, connectionName, serviceKey: null);
4846
}
4947

5048
/// <summary>
@@ -67,7 +65,7 @@ public static AspireBlobStorageBuilder AddAzureBlobClient(
6765
/// <exception cref="InvalidOperationException">
6866
/// Neither <see cref="AzureStorageBlobsSettings.ConnectionString"/> nor <see cref="AzureStorageBlobsSettings.ServiceUri"/> is provided.
6967
/// </exception>
70-
public static AspireBlobStorageBuilder AddKeyedAzureBlobClient(
68+
public static void AddKeyedAzureBlobClient(
7169
this IHostApplicationBuilder builder,
7270
string name,
7371
Action<AzureStorageBlobsSettings>? configureSettings = null,
@@ -76,9 +74,7 @@ public static AspireBlobStorageBuilder AddKeyedAzureBlobClient(
7674
ArgumentNullException.ThrowIfNull(builder);
7775
ArgumentException.ThrowIfNullOrEmpty(name);
7876

79-
var settings = new BlobStorageComponent().AddClient(builder, DefaultConfigSectionName, configureSettings, configureClientBuilder, connectionName: name, serviceKey: name);
80-
81-
return new AspireBlobStorageBuilder(builder, connectionName: name, serviceKey: name, settings);
77+
new BlobStorageComponent().AddClient(builder, DefaultConfigSectionName, configureSettings, configureClientBuilder, connectionName: name, serviceKey: name);
8278
}
8379

8480
/// <summary>

0 commit comments

Comments
 (0)