This change pushes container registry details to the outputs (#8839)

* This change pushes container registry details to the outputs
- The assumption is that these are going to be needed to push the container image so they are made available as outputs in main.bicep.

* Trim whitespace

* Update src/Aspire.Hosting.Azure/AzurePublishingContext.cs

---------

Co-authored-by: Eric Erhardt <[email protected]>

Author: davidfowl

src/Aspire.Hosting.Azure/AzurePublishingContext.cs

@@ -217,9 +217,17 @@ static BicepValue<string> ResolveValue(object val)
 
         var outputs = new Dictionary<string, BicepOutputReference>();
 
+        void CaptureBicepOutputs(object value)
+        {
+            if (value is BicepOutputReference bo)
+            {
+                outputs[bo.ValueExpression] = bo;
+            }
+        }
+
         foreach (var resource in model.Resources)
         {
-            if (resource.GetDeploymentTargetAnnotation()?.DeploymentTarget is AzureBicepResource br)
+            if (resource.GetDeploymentTargetAnnotation() is { } annotation && annotation.DeploymentTarget is AzureBicepResource br)
             {
                 var moduleDirectory = outputDirectory.CreateSubdirectory(resource.Name);
 
@@ -229,15 +237,18 @@ static BicepValue<string> ResolveValue(object val)
 
                 File.Copy(file.Path, modulePath, true);
 
+                // Capture any bicep outputs from the registry info as it may be needed
+                Visit(annotation.ContainerRegistryInfo?.Name, CaptureBicepOutputs);
+                Visit(annotation.ContainerRegistryInfo?.Endpoint, CaptureBicepOutputs);
+
+                if (annotation.ContainerRegistryInfo is IAzureContainerRegistry acr)
+                {
+                    Visit(acr.ManagedIdentityId, CaptureBicepOutputs);
+                }
+
                 foreach (var parameter in br.Parameters)
                 {
-                    Visit(parameter.Value, v =>
-                    {
-                        if (v is BicepOutputReference bo)
-                        {
-                            outputs[bo.ValueExpression] = bo;
-                        }
-                    });
+                    Visit(parameter.Value, CaptureBicepOutputs);
                 }
             }
         }
@@ -273,7 +284,7 @@ static BicepValue<string> ResolveValue(object val)
     }
 
     private static void Visit(object? value, Action<object> visitor) =>
-        Visit(value, visitor, new HashSet<object>());
+        Visit(value, visitor, []);
 
     private static void Visit(object? value, Action<object> visitor, HashSet<object> visited)
     {

tests/Aspire.Hosting.Azure.Tests/AzurePublisherTests.cs

@@ -30,7 +30,7 @@ public async Task PublishAsync_GeneratesMainBicep(bool useContext)
 
         var builder = TestDistributedApplicationBuilder.Create(DistributedApplicationOperation.Publish);
 
-        // The azure publisher is not tied to azure container apps but this is 
+        // The azure publisher is not tied to azure container apps but this is
         // a good way to test the end to end scenario
         builder.AddAzureContainerAppEnvironment("acaEnv");
 
@@ -230,6 +230,12 @@ param kvName string
               }
             }
 
+            output acaEnv_AZURE_CONTAINER_REGISTRY_NAME string = acaEnv.outputs.AZURE_CONTAINER_REGISTRY_NAME
+
+            output acaEnv_AZURE_CONTAINER_REGISTRY_ENDPOINT string = acaEnv.outputs.AZURE_CONTAINER_REGISTRY_ENDPOINT
+
+            output acaEnv_AZURE_CONTAINER_REGISTRY_MANAGED_IDENTITY_ID string = acaEnv.outputs.AZURE_CONTAINER_REGISTRY_MANAGED_IDENTITY_ID
+
             output myapp_identity_id string = myapp_identity.outputs.id
 
             output myapp_identity_clientId string = myapp_identity.outputs.clientId
@@ -245,10 +251,6 @@ param kvName string
             output fe_identity_clientId string = fe_identity.outputs.clientId
 
             output storage_blobEndpoint string = storage.outputs.blobEndpoint
-
-            output acaEnv_AZURE_CONTAINER_REGISTRY_ENDPOINT string = acaEnv.outputs.AZURE_CONTAINER_REGISTRY_ENDPOINT
-
-            output acaEnv_AZURE_CONTAINER_REGISTRY_MANAGED_IDENTITY_ID string = acaEnv.outputs.AZURE_CONTAINER_REGISTRY_MANAGED_IDENTITY_ID
             """;
         output.WriteLine(content);
         Assert.Equal(expectedBicep, content, ignoreAllWhiteSpace: true, ignoreLineEndingDifferences: true);