Add test cases and ensure container cert override paths work #12654
+148
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12654Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12654" |
danegsta
added
the
area-app-model
karolz-ms
approved these changes
Nov 4, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR extends the container certificate trust configuration testing to cover multiple certificate trust scopes (Append, Override, None) and custom certificate path configurations. The changes enhance test coverage for certificate authority trust scenarios and fix a bug in how certificate bundles are created for multiple paths in the same directory.
Key changes:
- Expanded test cases to cover
CertificateTrustScopeenum values (Append, Override, None) with custom certificate path overrides - Fixed a bug in
DcpExecutor.cswhere multiple certificate bundle paths in the same directory were creating duplicate file system entries instead of grouping them
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs | Expanded test coverage to verify certificate trust behavior across all three trust scopes (Append, Override, None) and with custom certificate paths |
| src/Aspire.Hosting/Dcp/DcpExecutor.cs | Fixed null-coalescing operator order and grouped certificate bundle paths by directory to avoid duplicate file system entries |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
/backport to release/13.0 |
|
Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/19057488155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added test cases and fixed some bugs related to overriding the default certificate paths for containers.