Fix template warnings during build #5578
Conversation
ghost
added
the
....ProjectTemplates/templates/aspire-apphost/.template.config/localize/templatestrings.cs.json
Show resolved
Hide resolved
|
I don't know anything about the warnings this fixes I'm sorry. @phenning @sayedihashimi can you review this change please? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
I'm not sure about the warnings either, what was getting warnings? The lack of entries in the localization files? @joeloff I'm not sure how the loc infrastructure works here, is it necessary to seed all the non-enu files, or should only the en-us be modified with the text from the template.json? |
Don't think it needs to have it, but the localization infrastructure often copies new ENU values for all the locales and then vendors would eventually pick those up for translation |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Added documentation on how localization works (there is a bot) so we just need to provide the english entries as the source. @phenning the warnings are as such |
| ### Localization bot | ||
|
|
||
| When updating or adding a new property in a `template.json` it is | ||
| required to update or add the English text of the entry of each of the localization files. The text will be kept in English, and a localization bot will create a PR to change it with the correct translation. See [this PR](https://github.com/dotnet/aspire/pull/3144) for an example of one created by the localization bot. |
There was a problem hiding this comment.
Do you need to automatically add the entry on each of the loc files? I thought that this happens automatically if you update the template.json file and then you build the template project
|
Stale |
| @@ -227,6 +228,11 @@ | |||
| "id": "set-startup-project", | |||
| "description": "Sets the startup project in the solution", | |||
| "actionId": "5BECCC32-4D5A-4476-A0F9-BD2E81AF0689", | |||
| "manualInstructions": [ | |||
| { | |||
| "text": "Set the startup project in the solution" | |||
There was a problem hiding this comment.
Did you verify that this isn't shown in VS? When I tried to set this recently to suppress this warning, VS would always show this message 😞
There was a problem hiding this comment.
I don't recall. Can it be an empty string?
There was a problem hiding this comment.
Not sure. It may just be a mistake in the schema definition.
danmoseley
added
the
needs-author-action
|
This submission has been automatically marked as stale because it has been marked as requiring author action but has not had any activity for 14 days. |
Fixes #2893
Checking the JSON schema and the templates doc these properties seem to be required in the files.
Microsoft Reviewers: Open in CodeFlow