Move remaining ACA infrastructure generation to Aspire.Hosting.Azure.AppContainers #7970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-integrations
davidfowl
changed the title
eerhardt
reviewed
Mar 10, 2025
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppEnvironmentResource.cs
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppExtensions.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Mar 10, 2025
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppEnvironmentResource.cs
Outdated
Show resolved
Hide resolved
mitchdenny
reviewed
Mar 11, 2025
src/Aspire.Hosting.Azure.AppContainers/ContainerAppEnvironmentDotnetComponentResource.cs
Show resolved
Hide resolved
playground/AzureContainerApps/AzureContainerApps.AppHost/Program.cs
Outdated
Show resolved
Hide resolved
playground/AzureContainerApps/AzureContainerApps.AppHost/Program.cs
Outdated
Show resolved
Hide resolved
playground/AzureContainerApps/AzureContainerApps.AppHost/Program.cs
Outdated
Show resolved
Hide resolved
davidfowl
force-pushed
the
davidfowl/resources-bicep
branch
from
064e9a8 to
0d9cf80
Compare
davidfowl
force-pushed
the
davidfowl/resources-bicep
branch
from
8d1cde9 to
3e23059
Compare
…zure Container Apps
… in Azure Container Apps
…container app environment
…ure Container Apps
…ce single environment limitation
davidfowl
commented
Mar 17, 2025
playground/AzureContainerApps/AzureContainerApps.AppHost/infra/main.bicep
Outdated
Show resolved
Hide resolved
…onment and update references in the application and tests
eerhardt
reviewed
Mar 17, 2025
playground/AzureContainerApps/AzureContainerApps.AppHost/infra/account/account.module.bicep
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Mar 17, 2025
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppsInfrastructure.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Mar 17, 2025
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppExtensions.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Mar 17, 2025
eerhardt
reviewed
Mar 17, 2025
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppExtensions.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Mar 17, 2025
eerhardt
reviewed
Mar 17, 2025
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppEnvironmentResource.cs
Show resolved
Hide resolved
eerhardt
reviewed
Mar 17, 2025
playground/AzureContainerApps/AzureContainerApps.AppHost/infra.module.bicep
Show resolved
Hide resolved
eerhardt
reviewed
Mar 17, 2025
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppsInfrastructure.cs
Show resolved
Hide resolved
eerhardt
reviewed
Mar 17, 2025
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppsInfrastructure.cs
Outdated
Show resolved
Hide resolved
…ences accordingly
…ences accordingly
of compute resources with container app environment
…nce and improve exception messages
…urce.KnownParameters.UserPrincipalId
…er Apps infrastructure
|
This is ready for review again @eerhardt @mitchdenny |
…ontainer App environment
davidfowl
commented
Mar 18, 2025
…unused resources module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces a new
AzureContainerAppsEnviromentResourcethat represents an Azure Container App environment. The goal is to move all of the generated infrastructure to the app host and out of azd. This allows users to model and tweak most things to do with deployment in C#, instead of dropping to bicep via infra synth.Fixes #7076
It relies on Azure/azure-dev#4884
This switch is point in time and we will write logic in azd to detect when resource generation is not neeed.
Still lots of work to do, but this will lay the foundation for decoupling where aspire can deploy to in azure. This is 90% there still need to add tests.