-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics overflow warning to the dashboard #7784
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Aspire.Dashboard/Otlp/Model/OtlpInstrument.cs:31
- Consider adding unit tests for HasOverflowDimension to cover scenarios with dimensions that do and do not contain the overflow attribute, ensuring correct behavior in both cases.
public static bool HasOverflowDimension(List<DimensionScope> dimensions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for continuously adding more OpenTelemetry features to Aspire! ❤️
As far as I know, this capability doesn’t exist anywhere else, not even in Prometheus/Grafana.
Great to see Aspire leading the way!
(I plan to showcase this in a tutorial/blog about Cardinality Capping in OTel)
If it's shown off in tutorials/blogs then I'll put a little more effort into styling. I've updated it to look better. |
Description
Fixes #7520
I didn't spend any time styling the warning. Most people will never see this so IMO it's not important we make it look perfect.New:

Old:

Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):