[Blazor] IDisposable Sanity check on Blazor Component

[naice]

Is there an existing issue for this?

• I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

We just faced the Issue that a Developer has probably copy and pasted component code including the public void Dispose() function but he forgot the @implements IDisposable

I have written a unit test that now detects such components, I wonder if it might be a smart idea to introduce a warning for that?

Describe the solution you'd like

A build generated warning or somthing similar that warns about components that expose a Dispose function but actually are not assignable to IDisposable.

Additional context

No response

[javiercn]

@naice thanks for contacting us.

How is this different from adding a Disposable method on a C# class and not adding the : IDisposable bit?

Hi @naice. We have added the "Needs: Author Feedback" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

[garrettlondon1]

@javiercn you will get a compiler warning if you inherit from IDisposable in a regular C# class, this is specific to Blazor/Razor

If you add @implements IDisposable to a .razor file, and you don't have a Dispose implementation in your partial code behind class, there is no compiler warning.

Also, if you have a dispose method, but you don't implement IDisposable in the razor component, there is no compiler warning.

[naice]

@naice thanks for contacting us.

How is this different from adding a Disposable method on a C# class and not adding the : IDisposable bit?

When you write regular C# classes you are not bound to a lifecycle ecosystem and you would even get compiler errors trying to write using var x i think you get my point here. But Blazor Components are created completly by "inversion of control" and their lifecycle is controlled by it.

So yes, for me there is definetly a difference. From a framework perspective I also think you shouldn't try to avoid responsibility on this.

Edit:
Maybe I should also add that I never understood why you can even create a public void Dispose function in C# without the fitting interface. I'd rather seen it as some sort of language keyword so that you can't compile without the IDisposable entirely.

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.