Skip to content

ACNM: Dependency provider use the same key for both arm64 and x64 #65953

@joeloff

Description

@joeloff

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

When support for arm64 was introduced to ANCM, the provider key used by the installer was not updated. The dependency provider is used to reference count installations and should track x64 and arm64 installs separately.

This was discovered as part of a customer investigation where ANCM was removed during an upgrade. The provider key was not the root cause of the investigation, but can result in installers making incorrect decisions.

<ANCMDepProviderKey Condition="'$(Platform)' == 'x86'">IIS_AspNetCore_Module_V2,x86</ANCMDepProviderKey>
<ANCMDepProviderKey Condition="'$(Platform)' != 'x86'">IIS_AspNetCore_Module_V2,x64</ANCMDepProviderKey>
. I think the provider key should just include the lower invariant of the platform in the key.

The issue is present in 8, 9, 10 and 11.

Note for testing: ANCM supports major upgrades, which triggers prior to running the removal of the hosting bundle. While the fix is simple, all the upgrade, repair scenarios should be verified.

Expected Behavior

No response

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

Metadata

Metadata

Assignees

Labels

area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkbugThis issue describes a behavior which is not expected - a bug.feature-installersIncludes: Installers

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions