Skip to content

GetCompletions should check exit code of invoked application #2137

New issue
New issue
Open
#2160
Open
GetCompletions should check exit code of invoked application#2137
#2160
Labels
Area-CompletionsRelated to support for tab completionbugSomething isn't workinghelp wantedExtra attention is needed
@tmds

Description

@tmds
tmds
opened on Mar 31, 2023

This code should probably check the exit code and not consider standard output to be completions when it is non-zero:

command-line-api/src/System.CommandLine.Suggest/SuggestionStore.cs

Lines 47 to 50 in 403234a

if (readToEndTask.Wait(timeout))
{
result = readToEndTask.Result;
}

cc @jonsequitur @adamsitnik

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-CompletionsRelated to support for tab completionbugSomething isn't workinghelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions