Fixes issue with handling multiple headers with same name in DevToolsPlugin. Closes #1169 #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of multiple headers with the same name in DevToolsPlugin by grouping duplicate headers and joining their values with a comma.
- Replaces creating a dictionary from header list with grouping by header name.
- Applies this grouping logic to both the request and response header processing.
Comments suppressed due to low confidence (2)
dev-proxy-plugins/Inspection/DevToolsPlugin.cs:244
- Ensure that joining header values with a comma does not introduce ambiguity if individual header values contain commas. Consider verifying if downstream consumers expect a single concatenated string or require an array of header values.
ToDictionary(g => g.Key, g => string.Join(", ", g.Select(h => h.Value)));
dev-proxy-plugins/Inspection/DevToolsPlugin.cs:244
- Confirm that the aggregated header values using a comma as a delimiter align with how header data is consumed elsewhere in the system. If not, consider alternative approaches to maintain clear separations between multiple header values.
ToDictionary(g => g.Key, g => string.Join(", ", g.Select(h => h.Value)));
garrytrinder
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with handling multiple headers with same name in DevToolsPlugin. Closes #1169