Fix triage dump tests. (#1334)

mikem8361 · web-flow · commit 7500958c5ffe · 2020-07-09T13:49:32.000-07:00
Fix triage dumps tests.
diff --git a/src/SOS/SOS.UnitTests/SOSRunner.cs b/src/SOS/SOS.UnitTests/SOSRunner.cs
@@ -544,8 +544,6 @@ public static async Task<SOSRunner> StartDebugger(TestInformation information, D
                     {
                         throw new ArgumentException("No DotNetDumpHost in configuration");
                     }
-                    initialCommands.Add("setsymbolserver -directory %DEBUG_ROOT%");
-
                     // Add the path to runtime so dotnet-dump/SOS can find DAC/DBI for triage dumps
                     if (information.DumpType == DumpType.Triage)
                     {
@@ -555,6 +553,7 @@ public static async Task<SOSRunner> StartDebugger(TestInformation information, D
                             initialCommands.Add("setclrpath " + runtimeSymbolsPath);
                         }
                     }
+                    initialCommands.Add("setsymbolserver -directory %DEBUG_ROOT%");
                     arguments.Append(debuggerPath);
                     arguments.Append(@" analyze %DUMP_NAME%");
                     debuggerPath = config.DotNetDumpHost();

Original file line number	Diff line number	Diff line change
`@@ -544,8 +544,6 @@ public static async Task<SOSRunner> StartDebugger(TestInformation information, D`
`544`	`544`	`{`
`545`	`545`	`throw new ArgumentException("No DotNetDumpHost in configuration");`
`546`	`546`	`}`
`547`		`- initialCommands.Add("setsymbolserver -directory %DEBUG_ROOT%");`
`548`		`-`
`549`	`547`	`// Add the path to runtime so dotnet-dump/SOS can find DAC/DBI for triage dumps`
`550`	`548`	`if (information.DumpType == DumpType.Triage)`
`551`	`549`	`{`
`@@ -555,6 +553,7 @@ public static async Task<SOSRunner> StartDebugger(TestInformation information, D`
`555`	`553`	`initialCommands.Add("setclrpath " + runtimeSymbolsPath);`
`556`	`554`	`}`
`557`	`555`	`}`
	`556`	`+ initialCommands.Add("setsymbolserver -directory %DEBUG_ROOT%");`
`558`	`557`	`arguments.Append(debuggerPath);`
`559`	`558`	`arguments.Append(@" analyze %DUMP_NAME%");`
`560`	`559`	`debuggerPath = config.DotNetDumpHost();`