Why are all the <script>s in the wrong place? #9763

fuzzykiller · 2024-03-06T14:52:48Z

fuzzykiller
Mar 6, 2024

Is there any particular reason why all <script> tags in the modern template are now in an invalid location, between </head> and <body>? I see that they were originally inside <head>. If there’s no good reason then I suggest moving them back, to create spec-compliant HTML.

docfx/templates/modern/layout/_master.tmpl

Lines 41 to 61 in fa0c3c5

    
           </head> 
        
           {{^redirect_url}} 
        
           <script type="module" src="./{{_rel}}public/docfx.min.js"></script> 
        
           <script> 
        
             const theme = localStorage.getItem('theme') || 'auto' 
        
             document.documentElement.setAttribute('data-bs-theme', theme === 'auto' ? (window.matchMedia('(prefers-color-scheme: dark)').matches ? 'dark' : 'light') : theme) 
        
           </script> 
        
           {{#_googleAnalyticsTagId}} 
        
           <script async src="https://www.googletagmanager.com/gtag/js?id={{_googleAnalyticsTagId}}"></script> 
        
           <script> 
        
             window.dataLayer = window.dataLayer || []; 
        
             function gtag() { dataLayer.push(arguments); } 
        
             gtag('js', new Date()); 
        
             gtag('config', '{{_googleAnalyticsTagId}}'); 
        
           </script> 
        
           {{/_googleAnalyticsTagId}} 
        
           <body class="tex2jax_ignore" data-layout="{{_layout}}{{layout}}" data-yaml-mime="{{yamlmime}}">

yufeih · 2024-03-07T06:03:15Z

yufeih
Mar 7, 2024
Maintainer

Thank you @fuzzykiller for raising. This wasn't intentional, would you like to contribute a PR?

1 reply

fuzzykiller Mar 7, 2024
Author

Yes, gladly!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Why are all the <script>s in the wrong place? #9763

Uh oh!

{{title}}

Uh oh!

Replies: 1 comment 1 reply

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Why are all the <script>s in the wrong place? #9763

Uh oh!

fuzzykiller Mar 6, 2024

Replies: 1 comment · 1 reply

Uh oh!

yufeih Mar 7, 2024 Maintainer

Uh oh!

fuzzykiller Mar 7, 2024 Author

fuzzykiller
Mar 6, 2024

Replies: 1 comment 1 reply

yufeih
Mar 7, 2024
Maintainer

fuzzykiller Mar 7, 2024
Author