Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source.cpp #5374

Closed
wants to merge 1 commit into from
Closed

Update source.cpp #5374

wants to merge 1 commit into from

Conversation

Rajakavitha1
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 commented Feb 25, 2021

Updated the code snippet as suggested in #5353

Summary

Describe your changes here.

Fixes #5353

Updated the code snippet as suggested in dotnet#5353
@opbld33
Copy link

opbld33 commented Mar 3, 2021

Docs Build status updates of commit b3e7f8b:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/cpp/VS_Snippets_CLR_System/system.Threading.Semaphore2/CPP/source.cpp ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@antonfirsov
Copy link
Member

/cc area owner @kouvel

Base automatically changed from master to main March 5, 2021 20:52
@gewarren gewarren requested a review from a team as a code owner March 5, 2021 20:52
@carlossanlop
Copy link
Member

Ping @kouvel can you please review?

@carlossanlop carlossanlop requested a review from kouvel March 23, 2021 22:54
@gewarren
Copy link
Contributor

gewarren commented Apr 1, 2022

@kouvel Could you review this small change?

If it looks good, then the conflict will have to be resolved (the top-level samples folder was delete and everything under it moved up a level).

@kouvel
Copy link
Member

kouvel commented Apr 2, 2022

It looks like the C++/CLI version of the sample has been fixed and there are three more variants of the sample, C#, VB, and F#. The change looks good to me, it would be nice to fix all of them. @Rajakavitha1, would you be willing to do that?

@kouvel
Copy link
Member

kouvel commented Apr 2, 2022

Granted, I also haven't verified that this builds and works, @Rajakavitha1 have you verified that it works?

@gewarren
Copy link
Contributor

gewarren commented Jun 5, 2024

Closing due to inactivity and conflict.

@gewarren gewarren closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semaphore C# example not demonstrating usage clearly
6 participants