Skip to content

Commit 576e1c6

Browse files
Update common Docker engineering infrastructure with latest
1 parent a6ef4fb commit 576e1c6

4 files changed

Lines changed: 19 additions & 1 deletion

File tree

eng/common/templates/jobs/publish.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ parameters:
77
sourceBuildPipelineRunId: ""
88
versionsRepoRef: null
99
versionsRepoPath: ""
10+
# When true, overrides the commit SHA in merged image info files to use the current repository commit.
11+
# This ensures that updated images reference the correct commit in their commitUrl properties.
12+
overrideImageInfoCommit: false
1013

1114
jobs:
1215
- job: Publish
@@ -33,6 +36,11 @@ jobs:
3336
value: $(artifactsPath)/imageInfo
3437
- name: sourceBuildIdOutputDir
3538
value: $(Build.ArtifactStagingDirectory)/sourceBuildId
39+
- name: commitOverrideArg
40+
${{ if eq(parameters.overrideImageInfoCommit, true) }}:
41+
value: --commit-override $(Build.SourceVersion)
42+
${{ else }}:
43+
value: ''
3644
- ${{ parameters.customPublishVariables }}
3745

3846
steps:
@@ -167,6 +175,7 @@ jobs:
167175
--manifest $(manifest)
168176
--publish
169177
--initial-image-info-path $(imageInfoContainerDir)/full-image-info-orig.json
178+
$(commitOverrideArg)
170179
condition: and(succeeded(), eq(variables['publishImageInfo'], 'true'))
171180
displayName: Merge Image Info
172181

eng/common/templates/stages/dotnet/publish.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ parameters:
1111
sourceBuildPipelineDefinitionId: ''
1212
sourceBuildPipelineRunId: ''
1313
versionsRepoRef: null
14+
overrideImageInfoCommit: false
1415

1516
stages:
1617
- template: /eng/common/templates/stages/publish.yml@self
@@ -22,6 +23,7 @@ stages:
2223
sourceBuildPipelineDefinitionId: ${{ parameters.sourceBuildPipelineDefinitionId }}
2324
sourceBuildPipelineRunId: ${{ parameters.sourceBuildPipelineRunId }}
2425
versionsRepoRef: ${{ parameters.versionsRepoRef }}
26+
overrideImageInfoCommit: ${{ parameters.overrideImageInfoCommit }}
2527

2628
customPublishInitSteps:
2729
- pwsh: |

eng/common/templates/stages/publish.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ parameters:
1717
versionsRepoRef: null
1818
versionsRepoPath: "versions"
1919

20+
# When true, any updated images will have the SHA in their commit URL updated
21+
# to the commit that this pipeline is running on, instead of the commit they
22+
# were built from. Use in combination with isStandalonePublish to ensure that
23+
# internally built images still reference public Dockerfiles.
24+
overrideImageInfoCommit: false
25+
2026
################################################################################
2127
# Publish Images
2228
################################################################################
@@ -70,3 +76,4 @@ stages:
7076
sourceBuildPipelineRunId: ${{ parameters.sourceBuildPipelineRunId }}
7177
versionsRepoRef: ${{ parameters.versionsRepoRef }}
7278
versionsRepoPath: ${{ parameters.versionsRepoPath }}
79+
overrideImageInfoCommit: ${{ parameters.overrideImageInfoCommit }}

eng/common/templates/variables/docker-images.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
variables:
2-
imageNames.imageBuilderName: mcr.microsoft.com/dotnet-buildtools/image-builder:2755479
2+
imageNames.imageBuilderName: mcr.microsoft.com/dotnet-buildtools/image-builder:2757474
33
imageNames.imageBuilder: $(imageNames.imageBuilderName)
44
imageNames.imageBuilder.withrepo: imagebuilder-withrepo:$(Build.BuildId)-$(System.JobId)
55
imageNames.testRunner: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux3.0-docker-testrunner

0 commit comments

Comments
 (0)