Skip to content

Commit 859a87f

Browse files
committed
Fix Aspire Dashboard product version resolution in update-dependencies (#6831)
1 parent 00f477c commit 859a87f

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

eng/update-dependencies/AspireBuildUpdaterService.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,16 @@ public async Task<int> UpdateFrom(Build build, CreatePullRequestOptions pullRequ
5656
var version = dashboardAssets.First().Version;
5757
var majorMinorVersion = VersionHelper.ResolveMajorMinorVersion(version);
5858

59+
// Known issue: Aspire Dashboard builds are always "preview 1".
60+
// Passing in isStableRelease here keeps us from setting the product
61+
// version to the full build version with the "-preview.1" suffix.
62+
var productVersion = VersionHelper.ResolveProductVersion(version, isStableRelease: true);
63+
5964
List<VariableUpdateInfo> variableUpdates =
6065
[
6166
new VariableUpdateInfo("aspire-dashboard|build-version", version),
62-
new VariableUpdateInfo("aspire-dashboard|product-version", VersionHelper.ResolveProductVersion(version)),
63-
new VariableUpdateInfo("aspire-dashboard|fixed-tag", VersionHelper.ResolveProductVersion(version)),
67+
new VariableUpdateInfo("aspire-dashboard|product-version", productVersion),
68+
new VariableUpdateInfo("aspire-dashboard|fixed-tag", productVersion),
6469
new VariableUpdateInfo("aspire-dashboard|minor-tag", majorMinorVersion.ToString(2)),
6570
new VariableUpdateInfo("aspire-dashboard|major-tag", majorMinorVersion.Major.ToString()),
6671
];

0 commit comments

Comments
 (0)