Skip to content

Clean up Dockerfile formatting #4418

Open
@lbussell

Description

@lbussell

We should ensure that our Dockerfiles adhere to consistent rules for formatting:

  1. There should be 1 newline between instructions, and 2 newlines between stages. Example of where we use two lines between instructions:
    && tac $tmpManifestPath | gawk '!x[$1]++' | sort > /staging/var/lib/rpmmanifest/container-manifest-2
    # Create a non-root user and group
  2. Arguments to commands should be in alphabetical order. Example where they aren't:
  3. The alphabetical order for arguments should also extend to things like lists of packages to install:
    glibc \
    krb5 \
    libgcc \
    libstdc++ \
    openssl-libs \
    zlib \

    (I didn't find a place where we violated this).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions