Egress operations can silently fail

[schmittjoseph]

Description

If an operation encounters an error (and enters the Faulted state) it should log an error message.

However there's an issue that can cause the operation to silently fail (never logging the error), this occurs when:

• An egress provider is used for the operation
• The exception thrown by the operation isn't one of the following: ArgumentException, DiagnosticsClientException, InvalidOperationException, OperationCanceledException, MonitoringException, ValidationException, UnauthorizedAccessException

This is due to us incorrectly re-using ActionContextExtensions.InvokeAsync for egress operations, which does filtering on the exception thrown of an arbitrary action to determine if it should be logged or not:

dotnet-monitor/src/Microsoft.Diagnostics.Monitoring.WebApi/ActionContextExtensions.cs

Lines 43 to 78 in 84b2424

	try
	{
	return await action(token);
	}
	catch (ArgumentException ex) when (LogError(logger, ex))
	{
	return ExecutionResult<T>.Failed(ex);
	}
	catch (DiagnosticsClientException ex) when (LogError(logger, ex))
	{
	return ExecutionResult<T>.Failed(ex);
	}
	catch (InvalidOperationException ex) when (LogError(logger, ex))
	{
	return ExecutionResult<T>.Failed(ex);
	}
	catch (OperationCanceledException ex) when (token.IsCancellationRequested && LogInformation(logger, ex))
	{
	return ExecutionResult<T>.Failed(ex);
	}
	catch (OperationCanceledException ex) when (LogError(logger, ex))
	{
	return ExecutionResult<T>.Failed(ex);
	}
	catch (MonitoringException ex) when (LogError(logger, ex))
	{
	return ExecutionResult<T>.Failed(ex);
	}
	catch (ValidationException ex) when (LogError(logger, ex))
	{
	return ExecutionResult<T>.Failed(ex);
	}
	catch (UnauthorizedAccessException ex) when (LogError(logger, ex))
	{
	return ExecutionResult<T>.Failed(ex);
	}