Rename JsonExists to JsonPathExists

Part of #31136

Author: roji

src/EFCore.Relational/Extensions/RelationalDbFunctionsExtensions.cs

@@ -56,6 +56,6 @@ public static T Greatest<T>(this DbFunctions _, [NotParameterized] params T[] va
     /// <param name="_">The <see cref="DbFunctions" /> instance.</param>
     /// <param name="json">The JSON value to check.</param>
     /// <param name="path">The JSON path to look for.</param>
-    public static bool JsonExists(this DbFunctions _, object json, string path)
-        => throw new InvalidOperationException(CoreStrings.FunctionOnClient(nameof(JsonExists)));
+    public static bool JsonPathExists(this DbFunctions _, object json, string path)
+        => throw new InvalidOperationException(CoreStrings.FunctionOnClient(nameof(JsonPathExists)));
 }

src/EFCore.SqlServer/Query/Internal/SqlServerSqlTranslatingExpressionVisitor.cs

@@ -240,9 +240,9 @@ protected override Expression VisitMethodCall(MethodCallExpression methodCallExp
                     _typeMappingSource.FindMapping(isUnicode ? "nvarchar(max)" : "varchar(max)"));
             }
 
-            // We translate EF.Functions.JsonExists here and not in a method translator since we need to support JsonExists over
+            // We translate EF.Functions.JsonPathExists here and not in a method translator since we need to support JsonPathExists over
             // complex and owned JSON properties, which requires special handling.
-            case nameof(RelationalDbFunctionsExtensions.JsonExists)
+            case nameof(RelationalDbFunctionsExtensions.JsonPathExists)
                 when declaringType == typeof(RelationalDbFunctionsExtensions)
                     && @object is null
                     && arguments is [_, var json, var path]:

src/EFCore.Sqlite.Core/Query/Internal/SqliteSqlTranslatingExpressionVisitor.cs

@@ -236,9 +236,9 @@ when methodCallExpression.Object is not null
                     method.Name is nameof(string.StartsWith));
             }
 
-            // We translate EF.Functions.JsonExists here and not in a method translator since we need to support JsonExists over
+            // We translate EF.Functions.JsonPathExists here and not in a method translator since we need to support JsonPathExists over
             // complex and owned JSON properties, which requires special handling.
-            case nameof(RelationalDbFunctionsExtensions.JsonExists)
+            case nameof(RelationalDbFunctionsExtensions.JsonPathExists)
                 when declaringType == typeof(RelationalDbFunctionsExtensions)
                     && @object is null
                     && arguments is [_, var json, var path]:

test/EFCore.Relational.Specification.Tests/Query/Translations/JsonTranslationsRelationalTestBase.cs

@@ -6,32 +6,32 @@
 
 namespace Microsoft.EntityFrameworkCore.Query.Translations;
 
-// This test suite covers translations of JSON functions on EF.Functions (e.g. EF.Functions.JsonExists).
+// This test suite covers translations of JSON functions on EF.Functions (e.g. EF.Functions.JsonPathExists).
 // It does not cover general, built-in JSON support via complex type mapping, etc.
 public abstract class JsonTranslationsRelationalTestBase<TFixture>(TFixture fixture) : QueryTestBase<TFixture>(fixture)
     where TFixture : JsonTranslationsRelationalTestBase<TFixture>.JsonTranslationsQueryFixtureBase, new()
 {
     [ConditionalFact]
-    public virtual Task JsonExists_on_scalar_string_column()
+    public virtual Task JsonPathExists_on_scalar_string_column()
         => AssertQuery(
             ss => ss.Set<JsonTranslationsEntity>()
-                .Where(b => EF.Functions.JsonExists(b.JsonString, "$.OptionalInt")),
+                .Where(b => EF.Functions.JsonPathExists(b.JsonString, "$.OptionalInt")),
             ss => ss.Set<JsonTranslationsEntity>()
                 .Where(b => ((IDictionary<string, JsonNode>)JsonNode.Parse(b.JsonString)!).ContainsKey("OptionalInt")));
 
     [ConditionalFact]
-    public virtual Task JsonExists_on_complex_property()
+    public virtual Task JsonPathExists_on_complex_property()
         => AssertQuery(
             ss => ss.Set<JsonTranslationsEntity>()
-                .Where(b => EF.Functions.JsonExists(b.JsonComplexType, "$.OptionalInt")),
+                .Where(b => EF.Functions.JsonPathExists(b.JsonComplexType, "$.OptionalInt")),
             ss => ss.Set<JsonTranslationsEntity>()
                 .Where(b => ((IDictionary<string, JsonNode>)JsonNode.Parse(b.JsonString)!).ContainsKey("OptionalInt")));
 
     [ConditionalFact]
-    public virtual Task JsonExists_on_owned_entity()
+    public virtual Task JsonPathExists_on_owned_entity()
         => AssertQuery(
             ss => ss.Set<JsonTranslationsEntity>()
-                .Where(b => EF.Functions.JsonExists(b.JsonOwnedType, "$.OptionalInt")),
+                .Where(b => EF.Functions.JsonPathExists(b.JsonOwnedType, "$.OptionalInt")),
             ss => ss.Set<JsonTranslationsEntity>()
                 .Where(b => ((IDictionary<string, JsonNode>)JsonNode.Parse(b.JsonString)!).ContainsKey("OptionalInt")));
 

test/EFCore.SqlServer.FunctionalTests/Query/Translations/JsonTranslationsSqlServerTest.cs

@@ -13,9 +13,9 @@ public JsonTranslationsSqlServerTest(JsonTranslationsQuerySqlServerFixture fixtu
     }
 
     [ConditionalFact, SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
-    public override async Task JsonExists_on_scalar_string_column()
+    public override async Task JsonPathExists_on_scalar_string_column()
     {
-        await base.JsonExists_on_scalar_string_column();
+        await base.JsonPathExists_on_scalar_string_column();
 
         AssertSql(
             """
@@ -26,9 +26,9 @@ WHERE JSON_PATH_EXISTS([j].[JsonString], N'$.OptionalInt') = 1
     }
 
     [ConditionalFact, SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
-    public override async Task JsonExists_on_complex_property()
+    public override async Task JsonPathExists_on_complex_property()
     {
-        await base.JsonExists_on_complex_property();
+        await base.JsonPathExists_on_complex_property();
 
         AssertSql(
             """
@@ -39,9 +39,9 @@ WHERE JSON_PATH_EXISTS([j].[JsonComplexType], N'$.OptionalInt') = 1
     }
 
     [ConditionalFact, SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
-    public override async Task JsonExists_on_owned_entity()
+    public override async Task JsonPathExists_on_owned_entity()
     {
-        await base.JsonExists_on_owned_entity();
+        await base.JsonPathExists_on_owned_entity();
 
         AssertSql(
             """

test/EFCore.Sqlite.FunctionalTests/Query/Translations/JsonTranslationsSqliteTest.cs

@@ -13,9 +13,9 @@ public JsonTranslationsSqliteTest(JsonTranslationsQuerySqliteFixture fixture, IT
     }
 
     [ConditionalFact]
-    public override async Task JsonExists_on_scalar_string_column()
+    public override async Task JsonPathExists_on_scalar_string_column()
     {
-        await base.JsonExists_on_scalar_string_column();
+        await base.JsonPathExists_on_scalar_string_column();
 
         AssertSql(
             """
@@ -26,9 +26,9 @@ WHERE json_type("j"."JsonString", '$.OptionalInt') IS NOT NULL
     }
 
     [ConditionalFact]
-    public override async Task JsonExists_on_complex_property()
+    public override async Task JsonPathExists_on_complex_property()
     {
-        await base.JsonExists_on_complex_property();
+        await base.JsonPathExists_on_complex_property();
 
         AssertSql(
             """
@@ -39,9 +39,9 @@ WHERE json_type("j"."JsonComplexType", '$.OptionalInt') IS NOT NULL
     }
 
     [ConditionalFact]
-    public override async Task JsonExists_on_owned_entity()
+    public override async Task JsonPathExists_on_owned_entity()
     {
-        await base.JsonExists_on_owned_entity();
+        await base.JsonPathExists_on_owned_entity();
 
         AssertSql(
             """