Skip to content

Commit d917719

Browse files
rojiroji
authored
Remove redundant MemberData on override test methods (#38201)
1 parent eac3dce commit d917719

5 files changed

Lines changed: 21 additions & 21 deletions

File tree

‎test/EFCore.Cosmos.FunctionalTests/Query/OwnedQueryCosmosTest.cs‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ await AssertTranslationFailedWithDetails(
303303
AssertSql();
304304
}
305305

306-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
306+
[ConditionalTheory]
307307
public override Task SelectMany_on_owned_collection(bool async)
308308
=> CosmosTestHelpers.Instance.NoSyncTest(
309309
async, async a =>
@@ -319,7 +319,7 @@ JOIN o IN c["Orders"]
319319
""");
320320
});
321321

322-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
322+
[ConditionalTheory]
323323
public override Task SelectMany_with_result_selector(bool async)
324324
=> CosmosTestHelpers.Instance.NoSyncTest(
325325
async, async a =>
@@ -1124,7 +1124,7 @@ OFFSET 0 LIMIT @p
11241124
""");
11251125
});
11261126

1127-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1127+
[ConditionalTheory]
11281128
public override Task Client_method_take_loads_owned_navigations_variation_2(bool async)
11291129
=> CosmosTestHelpers.Instance.NoSyncTest(
11301130
async, async a =>
@@ -1143,7 +1143,7 @@ OFFSET 0 LIMIT @p
11431143
""");
11441144
});
11451145

1146-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1146+
[ConditionalTheory]
11471147
public override Task Count_over_owned_collection(bool async)
11481148
=> CosmosTestHelpers.Instance.NoSyncTest(
11491149
async, async a =>
@@ -1158,7 +1158,7 @@ FROM root c
11581158
""");
11591159
});
11601160

1161-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1161+
[ConditionalTheory]
11621162
public override Task Any_without_predicate_over_owned_collection(bool async)
11631163
=> CosmosTestHelpers.Instance.NoSyncTest(
11641164
async, async a =>
@@ -1173,7 +1173,7 @@ FROM root c
11731173
""");
11741174
});
11751175

1176-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1176+
[ConditionalTheory]
11771177
public override Task Any_with_predicate_over_owned_collection(bool async)
11781178
=> CosmosTestHelpers.Instance.NoSyncTest(
11791179
async, async a =>
@@ -1191,7 +1191,7 @@ FROM o IN c["Orders"]
11911191
""");
11921192
});
11931193

1194-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1194+
[ConditionalTheory]
11951195
public override Task Contains_over_owned_collection(bool async)
11961196
=> CosmosTestHelpers.Instance.NoSyncTest(
11971197
async, async a =>
@@ -1209,7 +1209,7 @@ FROM o IN c["Orders"]
12091209
""");
12101210
});
12111211

1212-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1212+
[ConditionalTheory]
12131213
public override Task ElementAt_over_owned_collection(bool async)
12141214
=> CosmosTestHelpers.Instance.NoSyncTest(
12151215
async, async a =>
@@ -1224,7 +1224,7 @@ FROM root c
12241224
""");
12251225
});
12261226

1227-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1227+
[ConditionalTheory]
12281228
public override Task ElementAtOrDefault_over_owned_collection(bool async)
12291229
=> CosmosTestHelpers.Instance.NoSyncTest(
12301230
async, async a =>
@@ -1239,7 +1239,7 @@ FROM root c
12391239
""");
12401240
});
12411241

1242-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1242+
[ConditionalTheory]
12431243
public override async Task OrderBy_ElementAt_over_owned_collection(bool async)
12441244
{
12451245
// Always throws for sync.
@@ -1261,7 +1261,7 @@ FROM o IN c["Orders"]
12611261
}
12621262
}
12631263

1264-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1264+
[ConditionalTheory]
12651265
public override Task Skip_Take_over_owned_collection(bool async)
12661266
=> CosmosTestHelpers.Instance.NoSyncTest(
12671267
async, async a =>
@@ -1276,7 +1276,7 @@ FROM root c
12761276
""");
12771277
});
12781278

1279-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1279+
[ConditionalTheory]
12801280
public override Task FirstOrDefault_over_owned_collection(bool async)
12811281
=> CosmosTestHelpers.Instance.NoSyncTest(
12821282
async, async a =>
@@ -1294,7 +1294,7 @@ FROM o IN c["Orders"]
12941294
""");
12951295
});
12961296

1297-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1297+
[ConditionalTheory]
12981298
public override async Task Distinct_over_owned_collection(bool async)
12991299
{
13001300
// Always throws for sync.
@@ -1307,7 +1307,7 @@ public override async Task Distinct_over_owned_collection(bool async)
13071307
}
13081308
}
13091309

1310-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1310+
[ConditionalTheory]
13111311
public override Task Union_over_owned_collection(bool async)
13121312
=> CosmosTestHelpers.Instance.NoSyncTest(
13131313
async, async a =>

‎test/EFCore.Relational.Specification.Tests/Query/JsonQueryRelationalTestBase.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace Microsoft.EntityFrameworkCore.Query;
88
public abstract class JsonQueryRelationalTestBase<TFixture>(TFixture fixture) : JsonQueryTestBase<TFixture>(fixture)
99
where TFixture : JsonQueryRelationalFixture, new()
1010
{
11-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
11+
[ConditionalTheory]
1212
public override async Task Project_json_reference_in_tracking_query_fails(bool async)
1313
{
1414
var message =
@@ -17,7 +17,7 @@ public override async Task Project_json_reference_in_tracking_query_fails(bool a
1717
Assert.Equal(CoreStrings.OwnedEntitiesCannotBeTrackedWithoutTheirOwner, message);
1818
}
1919

20-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
20+
[ConditionalTheory]
2121
public override async Task Project_json_collection_in_tracking_query_fails(bool async)
2222
{
2323
var message =
@@ -27,7 +27,7 @@ public override async Task Project_json_collection_in_tracking_query_fails(bool
2727
Assert.Equal(CoreStrings.OwnedEntitiesCannotBeTrackedWithoutTheirOwner, message);
2828
}
2929

30-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
30+
[ConditionalTheory]
3131
public override async Task Project_json_entity_in_tracking_query_fails_even_when_owner_is_present(bool async)
3232
{
3333
var message = (await Assert.ThrowsAsync<InvalidOperationException>(()

‎test/EFCore.SqlServer.FunctionalTests/BulkUpdates/NorthwindBulkUpdatesSqlServerTest.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1612,7 +1612,7 @@ WHERE [c].[CustomerID] LIKE N'F%'
16121612
""");
16131613
}
16141614

1615-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1615+
[ConditionalTheory]
16161616
public override async Task Update_with_two_inner_joins(bool async)
16171617
{
16181618
await base.Update_with_two_inner_joins(async);
@@ -1630,7 +1630,7 @@ FROM [Order Details] AS [o]
16301630
""");
16311631
}
16321632

1633-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1633+
[ConditionalTheory]
16341634
public override async Task Update_with_PK_pushdown_and_join_and_multiple_setters(bool async)
16351635
{
16361636
await base.Update_with_PK_pushdown_and_join_and_multiple_setters(async);

‎test/EFCore.SqlServer.FunctionalTests/Update/StoreValueGenerationIdentitySqlServerTest.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ OUTPUT 1
387387

388388
#region Different two operations
389389

390-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
390+
[ConditionalTheory]
391391
public override async Task Delete_Add_with_same_entity_types(bool async)
392392
{
393393
await Test(EntityState.Deleted, EntityState.Added, GeneratedValues.Some, async, withSameEntityType: true);

‎test/EFCore.Sqlite.FunctionalTests/BulkUpdates/NorthwindBulkUpdatesSqliteTest.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1535,7 +1535,7 @@ public override async Task Update_with_two_inner_joins(bool async)
15351535
""");
15361536
}
15371537

1538-
[ConditionalTheory, MemberData(nameof(IsAsyncData))]
1538+
[ConditionalTheory]
15391539
public override async Task Update_with_PK_pushdown_and_join_and_multiple_setters(bool async)
15401540
{
15411541
await base.Update_with_PK_pushdown_and_join_and_multiple_setters(async);

0 commit comments

Comments
 (0)